test: refact tests for authenticators#275
Merged
youyuanwu merged 2 commits intogo-openapi:masterfrom Dec 9, 2023
Merged
Conversation
This phase applies trivial relinting fixes, to keep the amount of changes reviewable. Non-trivial fixes are deferred to a follow-up PR. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
* addressed code duplication in tests * used sub tests to improve readability * covered a few additional edged cases (passing unexpected types, empty realm) Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 80.41% 80.82% +0.41%
==========================================
Files 44 44
Lines 3359 3364 +5
==========================================
+ Hits 2701 2719 +18
+ Misses 544 535 -9
+ Partials 114 110 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
Built on top of #274 |
Member
Author
|
@reviewers: please check the 2nd commit - the first commit comes from #274 |
youyuanwu
approved these changes
Dec 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.