[enhancement] Added missing LDAP control ControlMicrosoftSDFlags to control.go#560
Merged
cpuschma merged 1 commit intogo-ldap:masterfrom Jun 29, 2025
Merged
[enhancement] Added missing LDAP control ControlMicrosoftSDFlags to control.go#560cpuschma merged 1 commit intogo-ldap:masterfrom
cpuschma merged 1 commit intogo-ldap:masterfrom
Conversation
p0dalirius
added a commit
to TheManticoreProject/Manticore
that referenced
this pull request
Jun 29, 2025
Member
|
Thank you for your PR, @p0dalirius. While moving the controls to their own module would certainly clean up the codebase, it would also break backwards compatibility. As with v3, we would have to introduce a transition period and maintain the controls in both folders. I'm open for solutions to this! |
Member
|
I think we could move the controls into the sub module and then just put type aliases in the top level module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have added a new structure for the LDAP_SERVER_SD_FLAGS_OID control structure that allows to query security descriptors on Windows. Otherwise, as this was brought to me by a colleague, they are not returned in the results of the LDAP query (only empty values).
https://stackoverflow.com/questions/40771503/selecting-the-ad-ntsecuritydescriptor-attribute-as-a-non-admin/40773088#40773088
Source: https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-adts/3888c2b7-35b9-45b7-afeb-b772aa932dd0
In the future, wouldn't that be nice to have a
controls/submodule containing one file per control structure as well as a global file containing all the OIDs? This would make the codebase more readable in my opinion. What do you think @cpuschma?If you agree I volunteer to do this for the Microsoft Controls :)
Best regards,