fix: Replace DER with ASN1 BER encoding when parsing distinguishedNames#505
Merged
cpuschma merged 2 commits intogo-ldap:masterfrom Apr 7, 2024
Merged
Conversation
Contributor
|
@cpuschma FYI: I found a fix for the bug in the ber package that causes the high memory usage: go-asn1-ber/asn1-ber#42 |
gustavoluvizotto
pushed a commit
to gustavoluvizotto/ldap-fork
that referenced
this pull request
Apr 11, 2024
…es (go-ldap#505) * fix: Replace DER with ASN1 BER encoding when parsing distinguishedNames * Remove leftover comment
Member
Author
|
I don't have permissions to review and merge your PR in go-asn1-ber. @johnweldon Can you have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the Go asn1 library in the
decodeEncodedStringfunction to decode values with ASN1 BER instead. The replacement of the returned error should be ok, as there hasn't been a release with the new implementation of `ParseDN' yet.See RFC4514 Section 2.4: