Add tests to parseDN (fuzzing, roundtrip ...)#504
Merged
cpuschma merged 2 commits intogo-ldap:masterfrom Apr 6, 2024
Merged
Conversation
b1b474d to
2bc9b15
Compare
…d to make roundtripping work Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
64b5181 to
2bcde73
Compare
Contributor
Author
|
@cpuschma I updated the PR (removed the code that is not required for the roundtrip tests to pass) |
Member
|
I’ll look into this this weekend. Work’s been stressfull and I didn’t have the time to check your PR yet |
cpuschma
approved these changes
Apr 6, 2024
Member
cpuschma
left a comment
There was a problem hiding this comment.
LGTM. I'll look into the BER decoding later and submit another PR, but that's not scope of this one. Thank you for your help! ♥
gustavoluvizotto
pushed a commit
to gustavoluvizotto/ldap-fork
that referenced
this pull request
Apr 11, 2024
* add tests to parseDN (including fuzz tests) and apply changes required to make roundtripping work Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> * undo unnessary changes Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> --------- Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I additionally made some extra changes to the String() functions to make the round tripping work.
PTAL
NOTE: I think there might be a few changes that are not required but still included. I need some extra time to find them.UPDATE: I removed the unnecessary code
@cpuschma