feat: Add support for children scope choice const#480
Merged
cpuschma merged 3 commits intogo-ldap:masterfrom Jan 13, 2024
Merged
feat: Add support for children scope choice const#480cpuschma merged 3 commits intogo-ldap:masterfrom
cpuschma merged 3 commits intogo-ldap:masterfrom
Conversation
Member
|
Hi, thank you for your PR. It seems // ScopeChildren is an OpenLDAP extension that may not be supported by another directory server.
// See: https://github.com/openldap/openldap/blob/7c55484ee153047efd0e562fc1638c1a2525f320/include/ldap.h#L598Also, please mirror your changes to the v3 directory as well. Then we can get this merged Thank you! |
…n directory server other than OpenLDAP
gustavoluvizotto
pushed a commit
to gustavoluvizotto/ldap-fork
that referenced
this pull request
Apr 11, 2024
* feat: Add support for children scope choice const * Add comment to `ScopeChildren` that this scope may not be available on directory server other than OpenLDAP * Mirror changes to v3 --------- Co-authored-by: sirzzang <sirzzan@naver.com> Co-authored-by: Christopher Puschmann <cp@lumen.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds const declaration for representing children scope value 3.