Add support for Go 1.13's errors.Is/As functions#461
Merged
cpuschma merged 2 commits intogo-ldap:masterfrom Sep 6, 2023
Merged
Add support for Go 1.13's errors.Is/As functions#461cpuschma merged 2 commits intogo-ldap:masterfrom
cpuschma merged 2 commits intogo-ldap:masterfrom
Conversation
zmb3
added a commit
to gravitational/teleport
that referenced
this pull request
Aug 16, 2023
This is hopefully a temporary change that can be removed when the upstream fix [1] is merged. [1] go-ldap/ldap#461
github-merge-queue bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Aug 16, 2023
This is hopefully a temporary change that can be removed when the upstream fix [1] is merged. [1] go-ldap/ldap#461
github-actions bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Aug 16, 2023
This is hopefully a temporary change that can be removed when the upstream fix [1] is merged. [1] go-ldap/ldap#461
github-actions bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Aug 16, 2023
This is hopefully a temporary change that can be removed when the upstream fix [1] is merged. [1] go-ldap/ldap#461
github-actions bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Aug 16, 2023
This is hopefully a temporary change that can be removed when the upstream fix [1] is merged. [1] go-ldap/ldap#461
github-merge-queue bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Aug 16, 2023
This is hopefully a temporary change that can be removed when the upstream fix [1] is merged. [1] go-ldap/ldap#461
github-merge-queue bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Aug 16, 2023
This is hopefully a temporary change that can be removed when the upstream fix [1] is merged. [1] go-ldap/ldap#461
github-merge-queue bot
pushed a commit
to gravitational/teleport
that referenced
this pull request
Aug 16, 2023
This is hopefully a temporary change that can be removed when the upstream fix [1] is merged. [1] go-ldap/ldap#461
ldap.Error wraps an underlying error, but doesn't interoperate with errors.Is or errors.As since it doesn't expose an Unwrap method. This change makes it easier to detect things like an LDAP error caused due to a network timeout.
cpuschma
approved these changes
Aug 29, 2023
Member
cpuschma
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your PR. Can you please mirror the changes into the root directory as well? Thanks in advance!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ldap.Error wraps an underlying error, but doesn't interoperate with errors.Is or errors.As. This change makes it easier to detect things like an LDAP error caused due to a network timeout.