chore: deprecate unnecessary wrapper for DialWithDialer and DialWithTLSConfig#399
Merged
cpuschma merged 1 commit intogo-ldap:masterfrom Oct 21, 2022
cpuschma:chore_dialer
Merged
chore: deprecate unnecessary wrapper for DialWithDialer and DialWithTLSConfig#399cpuschma merged 1 commit intogo-ldap:masterfrom cpuschma:chore_dialer
DialWithDialer and DialWithTLSConfig#399cpuschma merged 1 commit intogo-ldap:masterfrom
cpuschma:chore_dialer
Conversation
johnweldon
approved these changes
Oct 20, 2022
inv2004
pushed a commit
to inv2004/ldap
that referenced
this pull request
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I once added
DialWithTLSDialeras wrapper, not realizing that everything necessary to define both the dialer andtlsconfigalready exists. This PR renames the non-exported fields for better readability and marksDialWithTLSDialeras deprecated, but keeps it intact