Add CLDAP (RFC1798 UDP/Connectionless) support to DialURL#397
Merged
cpuschma merged 2 commits intogo-ldap:masterfrom Oct 15, 2022
Merged
Add CLDAP (RFC1798 UDP/Connectionless) support to DialURL#397cpuschma merged 2 commits intogo-ldap:masterfrom
cpuschma merged 2 commits intogo-ldap:masterfrom
Conversation
This is actually a deprecated RFC, however Active Directory relies on it for server discovery. Without this patch CLDAP is possible via directt use of the the deprecated `Dial` function with a UDP network connection. This patch adds the same support to the DialURL function.
Member
|
Thank you for your PR! I'll look into this next week or maybe this weekend 😊 |
cpuschma
approved these changes
Oct 14, 2022
Member
cpuschma
left a comment
There was a problem hiding this comment.
I compared your changes to the RFC and tested this against a domain controller (functional level 2016). LGTM!
I'll leave the PR open for a few days for others to comment. Once again, thank you for your PR 👍
johnweldon
approved these changes
Oct 14, 2022
inv2004
pushed a commit
to inv2004/ldap
that referenced
this pull request
Jan 17, 2023
* Add CLDAP (RFC1798 UDP/Connectionless) support to DialURL This is actually a deprecated RFC, however Active Directory relies on it for server discovery. Without this patch CLDAP is possible via directt use of the the deprecated `Dial` function with a UDP network connection. This patch adds the same support to the DialURL function. * Mirror code changes to root folder Co-authored-by: Christopher Puschmann <cp@lumen.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is actually a deprecated RFC, however Active Directory relies on it for server discovery.
Without this patch CLDAP is possible via directt use of the the deprecated
Dialfunction with a UDP network connection. This patch adds the same support to the DialURL function via the 'cldap' URI scheme.See https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-adts/8ebcf782-87fd-4dc3-8585-1301569dfe4f
and https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-adts/895a7744-aff3-4f64-bcfa-f8c05915d2e9 for MS documentation on this.