Skip to content

Fix request timeout handling#388

Merged
cpuschma merged 2 commits intogo-ldap:masterfrom
cpuschma:fix_timeout
Jul 26, 2022
Merged

Fix request timeout handling#388
cpuschma merged 2 commits intogo-ldap:masterfrom
cpuschma:fix_timeout

Conversation

@cpuschma
Copy link
Member

Fixes #387

Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it's okay to remove the atomic access, LGTM

@cpuschma cpuschma merged commit cb504ae into go-ldap:master Jul 26, 2022
@cpuschma cpuschma deleted the fix_timeout branch July 26, 2022 19:22
@cpuschma
Copy link
Member Author

cpuschma commented Jul 26, 2022

@johnweldon Maybe it's time to create a new tag and release? There have been quite a few changes since the last release:

  • Update test matrix to Go v1.14+
  • Support for configurable logger
  • Linter cleanup
  • Update minimum required Go version to 1.14
  • Allow NTLM authentication without a password
  • Add missing Client interface methods
  • Implement Subtree delete control type
  • feat: return referrals for modify operation
  • Add Entry Unmarshal
  • added int and []byte type to entry unmarshal
  • Update dependencies to satisfy new ntlmssp.ProcessChallenge signature
  • Add String() methods to DN and its subtypes
  • Fix request timeout handling

inv2004 pushed a commit to inv2004/ldap that referenced this pull request Jan 17, 2023
* Fix request timeout handling
* Ensure 64-bit alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go routine leak at https://github.com/go-ldap/ldap/blob/master/conn.go#L498

2 participants