Support for configurable logger#366
Merged
johnweldon merged 4 commits intogo-ldap:masterfrom Apr 6, 2022
n3integration:enhancement/logger
Merged
Support for configurable logger#366johnweldon merged 4 commits intogo-ldap:masterfrom n3integration:enhancement/logger
johnweldon merged 4 commits intogo-ldap:masterfrom
n3integration:enhancement/logger
Conversation
johnweldon
reviewed
Apr 6, 2022
Member
|
We need to fix the validators too |
johnweldon
reviewed
Apr 6, 2022
lgtm Co-authored-by: John Weldon <johnweldon4@gmail.com>
Member
|
Sorry, should have specified that we should do it in the other file too - we're still trying to keep them in sync |
n3integration
commented
Apr 6, 2022
sync w/ v3
cpuschma
pushed a commit
to clementblaise/ldap
that referenced
this pull request
Apr 25, 2022
* [go-ldap#365] - support for configurable logger
m-vinc
pushed a commit
to m-vinc/ldap
that referenced
this pull request
Jun 15, 2022
* [go-ldap#365] - support for configurable logger
inv2004
pushed a commit
to inv2004/ldap
that referenced
this pull request
Jan 17, 2023
* [go-ldap#365] - support for configurable logger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365
Initial pass at a pull request to introduce an
ldap.loggervariable that defaults to thelog.Default()logger (to preserve backwards compatibility), but can be overridden at runtime through theldap.Logger(l *log.Logger)function.