Skip to content

allow using ; as RDN separator according to rfc2253#352

Merged
johnweldon merged 1 commit intogo-ldap:masterfrom
cpuschma:patch-1
Jan 4, 2022
Merged

allow using ; as RDN separator according to rfc2253#352
johnweldon merged 1 commit intogo-ldap:masterfrom
cpuschma:patch-1

Conversation

@cpuschma
Copy link
Member

@cpuschma cpuschma commented Jan 3, 2022

Fixes #351

johnweldon
johnweldon approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the failing legacy tests.. (not in this PR) I think we accidentally introduced code depending on new language / library features that are not available in Go 1.9

@cpuschma
Copy link
Member Author

cpuschma commented Jan 4, 2022 •
edited
Loading

I agree, but the error why the Go 1.9 build fails seems to come from go-ntlmssp:

Error: ../../../go/src/github.com/Azure/go-ntlmssp/negotiator.go:37:34: req.Header.Values undefined (type http.Header has no field or method Values)
Error: ../../../go/src/github.com/Azure/go-ntlmssp/negotiator.go:63:34: res.Header.Values undefined (type http.Header has no field or method Values)
Error: ../../../go/src/github.com/Azure/go-ntlmssp/negotiator.go:78:34: res.Header.Values undefined (type http.Header has no field or method Values)
Error: ../../../go/src/github.com/Azure/go-ntlmssp/negotiator.go:115:34: res.Header.Values undefined (type http.Header has no field or method Values)
Error: Process completed with exit code 2.

Looking at their travis.yml, they only run tests against 1.10.x and the latest version of Go :/

@johnweldon johnweldon merged commit 13008e4 into go-ldap:master Jan 4, 2022
@johnweldon johnweldon mentioned this pull request Jan 4, 2022
Closed
@shaiacs
Copy link

shaiacs commented Jan 25, 2022

@johnweldon any plans for a release with this fix?

@johnweldon
Copy link
Member

johnweldon commented Jan 25, 2022

@johnweldon any plans for a release with this fix?

I'll try to get to this in the next few days

@shaiacs
Copy link

shaiacs commented Feb 15, 2022

@johnweldon sorry to be nagging about this, but any chance you might get around to releasing this fix?

@johnweldon
Copy link
Member

johnweldon commented Feb 15, 2022

@johnweldon sorry to be nagging about this, but any chance you might get around to releasing this fix?

Done.... sorry for the delay.

@shaiacs
Copy link

shaiacs commented Feb 15, 2022

No worries. Really appreciate this and all the work you've done here.

cpuschma added a commit to clementblaise/ldap that referenced this pull request Apr 25, 2022
@cpuschma
allow using ; as RDN separator according to rfc2253 (go-ldap#352)
f1a5c67
inv2004 pushed a commit to inv2004/ldap that referenced this pull request Jan 17, 2023
@cpuschma @inv2004
allow using ; as RDN separator according to rfc2253 (go-ldap#352)
1f089a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnweldon johnweldon johnweldon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Semi colon is not treated as RDN separator

3 participants

@cpuschma @shaiacs @johnweldon