Ignore FOR UPDATE and FOR SHARE clause#20
Merged
jinzhu merged 1 commit intogo-gorm:masterfrom Oct 29, 2020
Merged
Conversation
c-bata
commented
Oct 29, 2020
Contributor
Author
|
@jinzhu Hi, thank you for merging this. Do you have a plan to release v1.1.4 tag? |
Member
|
Maybe a release after fixed this issue go-gorm/gorm#3585 I think this might need to rewrite the |
Contributor
Author
|
I see. Thank you! |
samuelncui
pushed a commit
to samuelncui/gorm-sqlite
that referenced
this pull request
Oct 4, 2023
merge upstream changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This PR is for automatically skipping FOR UPDATE (and FOR SHARE) clause.
See go-gorm/gorm#3687 for details.
User Case Description
Currently, it is required to write following code:
https://github.com/c-bata/goptuna/blob/9e9699a4394bf94f2a311ba4574a507ac833c824/rdb.v2/storage.go#L216-L224
From this patch, we can write it like below: