take connection from dialector if available#15
Merged
jinzhu merged 1 commit intogo-gorm:masterfrom Oct 9, 2020
Merged
Conversation
samuelncui
pushed a commit
to samuelncui/gorm-sqlite
that referenced
this pull request
Oct 4, 2023
…m.io/gorm-1.23.2 Bump gorm.io/gorm from 1.23.1 to 1.23.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Accept existing connection from dialector
To keep parity across other drivers (mysql, pg) they already do this
User Case Description
When working with elastic-apm-go it uses its own driver to open connections and hence they are traceable.
We were able to pass the apm opened connections to mysql and pg since they already have this field in Dialector