chore(deps): update urfave/cli/v3 to v3.9.0#37863
Merged
Merged
Conversation
PR 2319 (the -c help flag parsing fix) is merged, so drop the renovate pin. v3.9.0 prepends the default command name to the root command's args, breaking the old Root().Args() check in isValidDefaultSubCommand; use the command's own Args() instead. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
urfave/cli/v3 to v3.9.0
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the urfave/cli/v3 dependency and adjusts default-command argument validation to match the updated CLI behavior.
Changes:
- Updates
github.com/urfave/cli/v3from v3.6.1 to v3.9.0. - Removes the Renovate version pin for
urfave/cli/v3. - Changes default subcommand validation to inspect the invoked command’s own positional args.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cmd/helper.go |
Updates default subcommand validation for the new CLI arg behavior. |
go.mod |
Bumps github.com/urfave/cli/v3 to v3.9.0. |
go.sum |
Updates checksums for the new CLI dependency version. |
renovate.json5 |
Removes the obsolete Renovate pin for urfave/cli/v3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lunny
approved these changes
May 27, 2026
Member
Author
|
I'll try to restore compat for |
Contributor
|
You lose out of the box completions and still have to maintain the cli. You can always just not update urfave and get roughly the same outcome. |
Member
Author
|
Could re-implement the relevant parts in first-party code, but probably not warranted here, yet. |
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
Member
Author
|
Not easy to make the |
* origin/main: [skip ci] Updated translations via Crowdin chore: Move gitea sdk from code.gitea.io/sdk/gitea -> gitea.dev/sdk (go-gitea#37855) chore(deps): update `chroma`, `regexp2` v2, replace `dimiro1/reply` (go-gitea#37858) chore: clarify SSH clone URL related config options (go-gitea#37877) chore: remove mssql `x509negativeserial` workaround (go-gitea#37853) [skip ci] Updated translations via Crowdin chore: Move import path from code.gitea.io/gitea to gitea.dev (go-gitea#37873) # Conflicts: # renovate.json5
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
bircni
approved these changes
May 30, 2026
wxiaoguang
reviewed
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
github.com/urfave/cli/v3to v3.9.0 and removes the renovate pin now that urfave/cli#2319 (the-chelp flag parsing fix) is merged.v3.9.0 prepends the default command name to the root command's args, which broke the old
Root().Args()check inisValidDefaultSubCommand. It now uses the command's ownArgs().Behavior change:
./gitea web <extra-positional-arg>now errors withunknown commandinstead of starting the web server and ignoring the trailing arg.webtakes no positional args, so this is stricter (and arguably more correct) input handling. The intended./gitea bad-cmdrejection is unchanged.This PR was written with the help of Claude Opus 4.7