Skip to content

chore: remove mssql x509negativeserial workaround#37853

Merged
silverwind merged 9 commits into
go-gitea:mainfrom
harryzcy:x509-neg-mssql-only
May 27, 2026
Merged

chore: remove mssql x509negativeserial workaround#37853
silverwind merged 9 commits into
go-gitea:mainfrom
harryzcy:x509-neg-mssql-only

Conversation

@harryzcy

@harryzcy harryzcy commented May 25, 2026

Copy link
Copy Markdown
Contributor

The following TLS handshake error is fixed by newer versions of mssql (refer to microsoft/mssql-docker#895 (comment))

TLS Handshake failed: tls: failed to parse certificate from server: x509: negative serial number

Based on microsoft/go-sqlcmd#755 (comment), newer versions of mssql don't have this problem. And there're changes going to mssql driver side to make this error more explicit microsoft/go-mssqldb#356.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 25, 2026
@github-actions github-actions Bot added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 25, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 25, 2026
Comment thread .github/workflows/pull-db-tests.yml Outdated
@harryzcy harryzcy changed the title ci: allow x509 negative serial number only for mssql tests chore: remove x509negativeserial workaround for TLS handshake error with mssql May 26, 2026
@harryzcy harryzcy changed the title chore: remove x509negativeserial workaround for TLS handshake error with mssql chore: remove mssql x509negativeserial workaround May 26, 2026
@harryzcy harryzcy requested a review from lunny May 26, 2026 07:23
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 26, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 26, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 26, 2026
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 26, 2026
@silverwind silverwind merged commit b7a3c7a into go-gitea:main May 27, 2026
30 checks passed
@GiteaBot GiteaBot added this to the 1.27.0 milestone May 27, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 27, 2026
silverwind added a commit to silverwind/gitea that referenced this pull request May 27, 2026
* origin/main:
  chore: remove mssql `x509negativeserial` workaround (go-gitea#37853)
  [skip ci] Updated translations via Crowdin
@harryzcy harryzcy deleted the x509-neg-mssql-only branch May 28, 2026 02:05
silverwind added a commit to silverwind/gitea that referenced this pull request May 28, 2026
* origin/main:
  [skip ci] Updated translations via Crowdin
  chore: Move gitea sdk from code.gitea.io/sdk/gitea -> gitea.dev/sdk (go-gitea#37855)
  chore(deps): update `chroma`, `regexp2` v2, replace `dimiro1/reply` (go-gitea#37858)
  chore: clarify SSH clone URL related config options (go-gitea#37877)
  chore: remove mssql `x509negativeserial` workaround (go-gitea#37853)
  [skip ci] Updated translations via Crowdin
  chore: Move import path from code.gitea.io/gitea to gitea.dev (go-gitea#37873)

# Conflicts:
#	renovate.json5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants