Skip to content

update Terminal.spawn_child() to use spawn_async, not spawn_sync#208

Merged
mattrose merged 1 commit intognome-terminator:masterfrom
mattrose:update-vte-spawn
Sep 22, 2020
Merged

update Terminal.spawn_child() to use spawn_async, not spawn_sync#208
mattrose merged 1 commit intognome-terminator:masterfrom
mattrose:update-vte-spawn

Conversation

@mattrose
Copy link
Copy Markdown
Member

@mattrose mattrose commented Sep 9, 2020

2 reasons for this:

  1. spawn_sync is being deprecated.
  2. spawn_async API has a callback and other goodies that we can leverage in the future.

@mattrose mattrose merged commit f5cbdce into gnome-terminator:master Sep 22, 2020
@CsatiZoltan
Copy link
Copy Markdown

I don't know if this is related but after installing terminator on the master branch, running it yields the following exception:

PluginRegistry::load_plugins: Importing plugin command_notify.py failed: module 'command_notify' has no attribute 'AVAILABLE'
Traceback (most recent call last):
  File "./terminator", line 4, in <module>
    __import__('pkg_resources').run_script('terminator==1.92', 'terminator')
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 658, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 1438, in run_script
    exec(code, namespace, namespace)
  File "/usr/local/lib/python3.6/dist-packages/terminator-1.92-py3.6.egg/EGG-INFO/scripts/terminator", line 121, in <module>
    TERMINATOR.layout_done()
  File "/usr/local/lib/python3.6/dist-packages/terminator-1.92-py3.6.egg/terminatorlib/terminator.py", line 329, in layout_done
    terminal.spawn_child()
  File "/usr/local/lib/python3.6/dist-packages/terminator-1.92-py3.6.egg/terminatorlib/terminal.py", line 1492, in spawn_child
    self.pid = self.vte.spawn_async(
AttributeError: 'Terminal' object has no attribute 'spawn_async'

@mattrose
Copy link
Copy Markdown
Member Author

Oh. What version of vte are you using? That may be a newer call that's unsupported on your version

@mattrose mattrose added the question Further information is requested label Sep 23, 2020
@CsatiZoltan
Copy link
Copy Markdown

How can I check the VTE version? I installed the Python binding that is given in the installation instructions for Ubuntu:

gir1.2-vte-2.91 is already the newest version (0.52.2-1ubuntu1~18.04.2).

mattrose added a commit to mattrose/terminator that referenced this pull request Sep 27, 2020
…vte-spawn"

This reverts commit f5cbdce, reversing
changes made to e1476a2.
mattrose added a commit that referenced this pull request Sep 27, 2020
Revert "Merge pull request #208 from mattrose/update-vte-spawn"
@mattrose mattrose deleted the update-vte-spawn branch September 4, 2023 16:03
@mattrose mattrose restored the update-vte-spawn branch September 4, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants