Merged
Conversation
8b4c4f6 to
88b8c2c
Compare
thomas-fossati
commented
Mar 29, 2022
|
I've successfully used these new tests in veraison/go-cose#19. Just one comment: Verify cases don't need private key parameters. I would remove them to avoid confusion. |
Contributor
Author
awesome!
👍 will drop "d" from those. |
* fix indentation * add missing external data * fix string encoding in diagnostic CBOR * set a sensible title and description Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
* ECDSA w/ SHA-256 (sign) * ECDSA w/ SHA-256 (successful verify) * ECDSA w/ SHA-384 (sign) * ECDSA w/ SHA-384 (successful verify) * ECDSA w/ SHA-512 (sign) * ECDSA w/ SHA-512 (successful verify) Also add ES512 to the list of accepted algorithms in the schema Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Contributor
Author
|
Hearing no dissenting voices I'm going to merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a bunch of fixes and some cleanup.
Partially addresses #1