Skip to content

NodeGit + SQLite migration : implement clone feature#3589

Merged
mittalyashu merged 4 commits intogitthermal:chore/add-nodegitfrom
KaKi87:nodegit/clone-repository
Nov 3, 2019
Merged

NodeGit + SQLite migration : implement clone feature#3589
mittalyashu merged 4 commits intogitthermal:chore/add-nodegitfrom
KaKi87:nodegit/clone-repository

Conversation

@KaKi87
Copy link
Copy Markdown
Contributor

@KaKi87 KaKi87 commented Nov 2, 2019

The purpose of this PR is to replace the old simple-git/localStorage code by the new nodegit/sqlite methods to perforn a git clone using NodeGIt's API and the addRepository mixin.

@request-info
Copy link
Copy Markdown

request-info bot commented Nov 2, 2019

Hey there! We would appreciate if you could provide us more information about what you're trying to accomplish here!

@mittalyashu
Copy link
Copy Markdown
Member

@KaKi87 Can you update the description of the PR?

@KaKi87
Copy link
Copy Markdown
Contributor Author

KaKi87 commented Nov 2, 2019

Done, but there's not much to say.

@mittalyashu
Copy link
Copy Markdown
Member

Progress bar is also a part of the clone repository feature, shows the progress of the clone repository which is very helpful especially for larger size repositories.

image

Comment thread src/renderer/git/clone.js Outdated
@mittalyashu
Copy link
Copy Markdown
Member

Clone repository feature is working smoothly, can you run ESLint and format the code.

After then the PR is good to be merged.

@KaKi87
Copy link
Copy Markdown
Contributor Author

KaKi87 commented Nov 3, 2019

Done.

@mittalyashu
Copy link
Copy Markdown
Member

Awesome.

@mittalyashu mittalyashu self-assigned this Nov 3, 2019
@mittalyashu mittalyashu merged commit 51f4e09 into gitthermal:chore/add-nodegit Nov 3, 2019
@mittalyashu mittalyashu mentioned this pull request Nov 3, 2019
13 tasks
@KaKi87 KaKi87 deleted the nodegit/clone-repository branch November 3, 2019 18:40
mittalyashu added a commit that referenced this pull request Jun 5, 2021
* Initialize Git repository (nodegit) (#3509)

* Install NodeGit package

* Fix nodegit package installation (#3512)

* Change node_version to 10.16.0

* Define node & electron engines in package.json

* FIX: Add comma after node version engine

* Switch back to latest version of Node@10

* Split script command yarn and yarn build:window

* Update "postinstall" script command to install electron app deps

* Install electron app native deps

* Merge yarn && yarn postinstall && yarn build:linux command

* Test windows pipeline with npm

* Upgrade nodegit & electron-builder package

* Run pipeline in npm

* Run audit fix

* Run install && audit fix

* install & audit fix & postinstall & build:window

* Update build description

* Move yarn to npm

* Update echo command

* Remove electron from engines

* Update npm registry url

* Initialize repo using nodegit

* Use promise instead of async

* git status (nodegit)

* fix: switchRepository mutation to toggle modal

* Remove remote refs & validate git repository

Remove function for getting remote url on adding repository and only validate git repository.

* Add getBranchName function using nodegit

* Add source column to db table

Source column tells the source of repository (local or remote repo)

* git status and get file status type

Getting repository git status along with each file type, symbol, and color.

* Query repository data on route (enter & update)

* Clear repositoryData on routeLeave

* Update projectId to repositoryId (route params)

* Add repositoryData state, getters, and mutation

* Show branch name and working changes

* Move to next page after database data

* Show staged files in workspace

* Query repository & repositorySettings features data

* Remove refs from workspace

* Move to status-list component

Remove fileChangesSkeleton and use status-list component

* Create status item component

* Remove branchName parmas from workspace route

* Pass branchName as props to commit-message

* NodeGit + SQLite migration : implement clone feature (#3589)

* Use nodegit

* Use database

* Add cloning progress

* Run ESLint

* Remove workspace vuex store

* Emit stagedFile to statusList component

Storing all the statusList component inside stagedFile local data property.

* Change projectId to repositoryId

Repository ID is unique ID assigned to each repository from SQLite database.

* Show repo path in switch repo modal

* Set default branchName to "master"

* Remove getFeatureValue computed property

* Get repository data using mixin

Using repositoryData.js as mixin to get data from repository.js vuex store as repositoryData computed property.

* Git remote functions

Add these 3 remote functions

* getRemoteListNames
* getRemoteUrl
* addRemoteUrl

* Remove branchName as route props

* Query remoteUrl from db

Fetch remote url from database on entering repository route

* Save remote url to db on adding repository

* Update add remote url with nodegit

* store filePreview value locally data property

filePreview is a local data property stored in `workspace.vue` to toggle view for diff preview component with blankSlate component

* adjust workspace files width

* Remove file diff preview method

* refactor: remove unused code

* Remove spacingProps, import repositoryData

* Update repositoryData computed property data

* Update to repositoryId & remove branchName params

* Remove event.preventDefault()

* Remove repositoryDataMixin import from settings.vue

* Update remoteUrl on saveSettings method

Update remoteUrl to database on running the saveSettings() method

* Git fetch functions

* pullRemoteBranch function

* Add gitFetch method to navbar

* Update directoryPath arguments (openTerminal & openFileExplorer)

* Update gitPull method with nodegit

* Remove branchName as route params

* Update repositoryData import

* Toggle commit-message component in workspace view

* Query repositoryName on enter repository route

* Change Git module to Clone in clone.js

* Remove console statement

* Format the code

* Update openCmdTerminal() method

* Initialize repository (nodegit) (#3592)

* Use nodegit and database instead of simple-git for initialize repository feature

* Disable git features for non-initialized repositories

* Add initialize repository feature from homepage

This commit includes an anti-pattern because of mutating this.isGit prop inside component but this can't be avoided without making some major changes.

* Settings to auto initialize non-git repository (#3596)

* Get & set settings to localStorage

Using if/else statement in beforeCreate lifecycle hook insted of using in vuex store mutation

* Add AutoInit settings to experimental page

* typo: initialize spellings

* Dispatch update to settings store (in single line)

* fix: autoInit undefined value in settings store

#3596 (comment)

* Remove console.log statement in setSettings

* Fix PR #3598 : Auto init non-git repository (part 2) (#3599)

* auto initialize non-git repository

* Update repositoryItem.vue after `npm run lint:fix`

* Do not initialize new repository on create

* Fix blocking error on new repository creation when folder does not exist

Co-authored-by: Yashu Mittal <mittalyashu77@gmail.com>

* addRepositoryToDatabase based closing modal

Incase error event a message can be shown inside the modal.

Reference: #3599 (comment)

* update isGit value in repository store

Creating a updateIsGitStatus mutation to update isGit value inside repository vuex store.

Database is updated with the required changes with vuex is unaware of the changes which causes is bug to show repository as `isGit: false`.

Reference: #3599 (comment)

* Update .electron-vue files

replace package-lock.json with yarn.lock

* change node engine v14

* ci: run pipeline with node v14 & v16

* ci: change npm to yarn

* set node engine v14 or v16

* ci: yarn postinstall deps

Co-authored-by: KaKi87 <tiana.lemesle@live.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants