Skip to content

refactor: switch LoginScreen to styled components#787

Merged
housseindjirdeh merged 1 commit intogitpoint:masterfrom
machour:refactor/login-screen-to-sc
Apr 25, 2018
Merged

refactor: switch LoginScreen to styled components#787
housseindjirdeh merged 1 commit intogitpoint:masterfrom
machour:refactor/login-screen-to-sc

Conversation

@machour
Copy link
Copy Markdown
Member

@machour machour commented Apr 24, 2018

Question Response
Version? v1.4.1
Devices tested? iPhone 7
Bug fix? no
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket? #532

Screenshots

Before After
simulator screen shot - iphone 6s - 2018-04-23 at 21 00 44 simulator screen shot - iphone 6s - 2018-04-24 at 08 11 02
simulator screen shot - iphone 6s - 2018-04-23 at 21 00 48 simulator screen shot - iphone 6s - 2018-04-24 at 08 11 03
simulator screen shot - iphone 6s - 2018-04-23 at 21 00 50 simulator screen shot - iphone 6s - 2018-04-24 at 08 11 05
simulator screen shot - iphone 6s - 2018-04-23 at 21 00 51 simulator screen shot - iphone 6s - 2018-04-24 at 08 11 06
simulator screen shot - iphone 6s - 2018-04-23 at 21 00 54 simulator screen shot - iphone 6s - 2018-04-24 at 08 11 09
simulator screen shot - iphone 6s - 2018-04-23 at 21 00 57 simulator screen shot - iphone 6s - 2018-04-24 at 08 11 11

Description

Migrated the login screen to styled components

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 42.316% when pulling a1e7552 on machour:refactor/login-screen-to-sc into 7b3ccf0 on gitpoint:master.

Copy link
Copy Markdown
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeetness 🚀 🚀 🚀

@housseindjirdeh housseindjirdeh merged commit 47eef83 into gitpoint:master Apr 25, 2018
@machour machour deleted the refactor/login-screen-to-sc branch April 25, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants