chore: Upgrade react, react-dom, react-native to latests versions#698
chore: Upgrade react, react-dom, react-native to latests versions#698chinesedfan merged 5 commits intogitpoint:masterfrom
Conversation
Upgrading react-native-linear-gradient is mandatory as it fixes a compatibility problem: react-native-linear-gradient/react-native-linear-gradient#235
housseindjirdeh
left a comment
There was a problem hiding this comment.
Genuinely excited to see how much it approves perf :)
Can test on my iPhone when I'm home tonight if @chinesedfan doesn't get to it in time.
|
Please do \o/ |
chinesedfan
left a comment
There was a problem hiding this comment.
@machour Great improvement. I just see the logo in a flash then events list is there! Except a tiny indentation question and yarn.lock conflicts, we can merge it.
ios/GitPoint/AppDelegate.m
Outdated
| jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil]; | ||
| #else | ||
| jsCodeLocation = [CodePush bundleURL]; | ||
| jsCodeLocation = [CodePush bundleURL]; |
There was a problem hiding this comment.
Shall we keep the pure empty line and old indentations?
|
@chinesedfan Fixed the whitespaces changes |
ios/GitPoint/AppDelegate.m
Outdated
| NSURL *jsCodeLocation; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
the pure empty line
@machour Sorry, I didn't comment very clearly before.
There was a problem hiding this comment.
Originally there was a line with a single space in it. I just removed it all together.
Not sure if I'm following you though :D
Description
Resurrecting #523, I updated react, react-native to their latests versions using
react-native-git-upgrade. I then proceeded to fix conflicts and get rid ofindex.ios.js&index.android.jsin favor ofindex.js🎉Tested the application on both iOS and Android simulator, nothing seems to brake.
The app startup is quicker, it becomes responsive as soon as it's launched, overall, it seems to be on steroïds ... WOW.
I was only able to validate this on Android, as I never was able to run the app on iOS without hardcoding my IP in
AppDelegate.m. @chinesedfan could you give it a try on iOS ?For this PR, the best thing is to
rm -rf node_modulesand thenyarn && yarn run link && yarn start --reset-cachePS: Upgrading react-native-linear-gradient is mandatory as it fixes a compatibility problem: react-native-linear-gradient/react-native-linear-gradient#235