chore: Upgrade to RN 0.49.3#523
chore: Upgrade to RN 0.49.3#523machour wants to merge 1 commit intogitpoint:masterfrom machour:react-native-0.49.3
Conversation
|
PS: Here is the changelog for 0.49 : https://github.com/facebook/react-native/releases/tag/v0.49.0 |
Yes, it is true, we use our translations, and from |
|
@lex111 just concerned about using a library this big (1.4M ?) to achieve so little |
|
@machour fair remark, but if we refuse |
|
The problem I was facing seems to have been fixed in 0.51.0. |
|
I recomend to use date-fns. It is full modular, light and ES6 friendly :) |
|
@ocarreterom We'd gladly accept a PR to migrate from 😅 |
|
@machour no problem! I do it. 👨💻 |
|
@ocarreterom great! 🎉 🎉 🎉 Opened issue #663 to keep track of this change. |
|
Will be re-opened with a newer RN version |

With #407 merged, we can now upgrade to RN 0.49.3 with the following patch.
The issue with moment is that the minified version uses dynamic requires, that RN doesn't support anymore (facebook/react-native#16216 (comment)).
Looking at our use of
moment.js, I've found that we're only requiring it to compute a timeago whose words we completely rewrite with our translations. Wouldn't make more sense to drop moment.js in favor of a homemade timeago, directly using ourtranslate()function?