refactor(diff-blocks): switch to styled components#692
Merged
housseindjirdeh merged 1 commit intogitpoint:masterfrom Jan 16, 2018
Merged
refactor(diff-blocks): switch to styled components#692housseindjirdeh merged 1 commit intogitpoint:masterfrom
housseindjirdeh merged 1 commit intogitpoint:masterfrom
Conversation
51 tasks
housseindjirdeh
approved these changes
Jan 16, 2018
Member
housseindjirdeh
left a comment
There was a problem hiding this comment.
Beautiful, thank you 🚀
| let greyBlocks = null; | ||
| let addedBlocks = null; | ||
| let deletedBlocks = null; | ||
| let neutralBlocks = null; |
Member
There was a problem hiding this comment.
Thanks for this - definitely better variable names 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots
Description
Migrated diff blocks to styled components.
(Reopened #533 as its repo was removed)