refactor(diff-blocks): convert diff-blocks to styled component#533
refactor(diff-blocks): convert diff-blocks to styled component#533machour wants to merge 3 commits intogitpoint:masterfrom machour:diff-blocks-styled
Conversation
| fontCode: { fontFamily: 'Menlo' }, | ||
| }; | ||
|
|
||
| export const fontsStyled = { |
There was a problem hiding this comment.
I think @josenaranjo is working on something related to fonts as he mentioned here AFAIK he created a new file called styledFonts.js inside /config, maybe you can talk to him before merging this PR so you don't get any merge conflict in the future. FWIW I like the idea of having a new fresh file with fonts.
There was a problem hiding this comment.
styledFonts.js looks good to me. I'll wait on @josenaranjo PR to get merged before changing this one
There was a problem hiding this comment.
@machour ok, @josenaranjo's PR was merged #561 You can start using his font file.
There was a problem hiding this comment.
🤔 I actually like having all the fonts in one file. Not sure though.
There was a problem hiding this comment.
seconding @andrewda, keeping both variables in the same file will help making sure we change both when updating something.
@alejandronanez Is it okay of I merge it back in fonts.js ?
There was a problem hiding this comment.
Sounds good to me, do you mind removing the file @josenaranjo added on his PR and doing a small refactor on his component so we don't introduce more tech debt in here?
alejandronanez
left a comment
There was a problem hiding this comment.
Let's talk to @josenaranjo about the fonts file he created for #515 before merging. Besides that LGTM!
|
Replaced by #692 |
My first converted component!
I've found the need to define a new
config.fontsStyledobject with converted styles rules.Is that ok?
Also renamed styles to avoid colors in names.