refactor: migrate user repo list screen to styled-components#683
Merged
housseindjirdeh merged 2 commits intogitpoint:masterfrom Jan 3, 2018
ZahraTee:styled-components-user-repos-screen
Merged
refactor: migrate user repo list screen to styled-components#683housseindjirdeh merged 2 commits intogitpoint:masterfrom ZahraTee:styled-components-user-repos-screen
housseindjirdeh merged 2 commits intogitpoint:masterfrom
ZahraTee:styled-components-user-repos-screen
Conversation
51 tasks
machour
requested changes
Dec 30, 2017
Member
machour
left a comment
There was a problem hiding this comment.
LGTM, thank you!
Just a little question to clean up the markup
| @@ -131,9 +130,9 @@ class RepositoryList extends Component { | |||
| return ( | |||
| <ViewContainer> | |||
| <View> | |||
Member
There was a problem hiding this comment.
Do you think we can get rid of this <View> ?
chinesedfan
approved these changes
Jan 2, 2018
machour
approved these changes
Jan 2, 2018
This was referenced Jan 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots
Part of #532.