fix(styled-components): Fix react-native-elements related problems#619
Merged
chinesedfan merged 8 commits intogitpoint:masterfrom Nov 7, 2017
Merged
fix(styled-components): Fix react-native-elements related problems#619chinesedfan merged 8 commits intogitpoint:masterfrom
chinesedfan merged 8 commits intogitpoint:masterfrom
Conversation
Member
Author
|
We're back to normal on a lot of things <3
|
andrewda
approved these changes
Nov 4, 2017
| subtitle={entity.company} | ||
| onPress={() => navigateToCompany(entity.company, orgs, navigation)} | ||
| unknown={companyInOrgs(entity.company, orgs)} | ||
| hideChevron={!companyInOrgs(entity.company, orgs)} |
This was referenced Nov 4, 2017
chinesedfan
approved these changes
Nov 5, 2017
Member
chinesedfan
left a comment
There was a problem hiding this comment.
@machour It is really awesome!
Member
Author
|
Last commit upgrades RNE to 0.18.2 that fixes another small problem with padding when using hideChevron on an item 🕵️ Before: After: |
Member
|
@gitpoint/maintainers Finally, I determined to merge this important PR. I have to admit that I only tested in iOS simulator by myself. But without it, there are so many bugs in our code base. And personally, I trust @machour have tested thoroughly in both platforms, as well as @andrewda 's review. In the worst case, we can fix later. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spent the afternoon fixing up the problems introduced by the styled-components migration:
<EntityInfo/>: The test on the company was inverted. Also renamed the prop.<IssueDescription/>: Fix the repo link header, the issue title & use InlineLabel instead of LabelButton for issues/pulls label<IssueEventListItem/>: Fix icon styling<*List />: Adjusted the border bottom color, as the default changed in RNE from 0.7 to 0.17 and this is why we had bolder lines.This should fix #615 #580 and several comments in #569