refactor: comment input to styled components#596
Merged
alejandronanez merged 2 commits intogitpoint:masterfrom Oct 28, 2017
Merged
refactor: comment input to styled components#596alejandronanez merged 2 commits intogitpoint:masterfrom
alejandronanez merged 2 commits intogitpoint:masterfrom
Conversation
Member
|
@shmesa22 Welcome to GitPoint! Can you add some comments or screenshots to make sure component styles are not broken? |
alejandronanez
requested changes
Oct 28, 2017
Member
alejandronanez
left a comment
There was a problem hiding this comment.
- Add flow annotation to
PostButtonIcon - Add screenshot(s) of your changes
| View | ||
| ); | ||
|
|
||
| const PostButtonIcon = ({ style }) => <Icon name="send" iconStyle={style} />; |
Member
There was a problem hiding this comment.
I think you need to add props validation to this function.
What I think is that you need to do something like:
type PostButtonIconProps = {
style: Object
};
const PostButtonIcon = ({ style } : PostButtonIconProps)=> <Icon name="send" iconStyle={style} />;PostButtonIconProps is a flow type annotation.
Welcome to Gitpoint! Let us know if you have any other question!
Contributor
Author
|
|
alejandronanez
approved these changes
Oct 28, 2017
Member
alejandronanez
left a comment
There was a problem hiding this comment.
This LGTM.
Any thoughts @andrewda @housseindjirdeh @machour
andrewda
approved these changes
Oct 28, 2017
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #532