refactor(styles): IssueDescription component styles update#563
Merged
housseindjirdeh merged 2 commits intogitpoint:masterfrom Oct 26, 2017
Merged
Conversation
Migrating StyleSheet styles to styled components 532
51 tasks
andrewda
requested changes
Oct 24, 2017
| padding-bottom: 10; | ||
| `; | ||
|
|
||
| const StateBadgeStyled = styled(StateBadge)` |
Member
There was a problem hiding this comment.
🤔 This is failing the test for some reason.
Cannot create styled-component for component: undefined
Member
There was a problem hiding this comment.
Actually, why are we styling the StateBadge at all here? Seems a bit weird. Shouldn't this all be done in the component?
Contributor
Author
There was a problem hiding this comment.
Couldn't agree more @andrewda . I reverted these styles to use StyleSheet while we refactor StateBadge component, so it doesn't require any style props.
StateBadge component will have some styles trough props. Revert to use StyleSheet in this case. gitpoint#532
|
Changes Unknown when pulling 213459e on josenaranjo:refactor-issue-description-component into ** on gitpoint:master**. |
andrewda
approved these changes
Oct 25, 2017
housseindjirdeh
approved these changes
Oct 26, 2017
Member
housseindjirdeh
left a comment
There was a problem hiding this comment.
cheers thanks for this @josenaranjo 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating StyleSheet styles to styled components
Related #532