fix(trans): Make all translations contain same fields by chinesedfan · Pull Request #478 · gitpoint/git-point

chinesedfan · 2017-10-15T05:33:37Z

I use a script to find out these missing fields.

How about adding a translations check task in Travis CI?

lex111 · 2017-10-15T06:08:50Z

How about adding a translations check task in Travis CI?

It would be good to check it, but how did you do it?

chinesedfan · 2017-10-15T06:43:39Z

@lex111 By a Node.js script, it is easy. You can image it as a test suite file.

chinesedfan · 2017-10-15T07:40:34Z

I just integrated the check to travis ci.

You can find that es is invalid. I didn't fix it because #442 will do that.

lex111 · 2017-10-15T09:04:16Z

@chinesedfan great and useful script! Can invite translators here?

chinesedfan · 2017-10-15T09:33:10Z

Hey guys, I need your help here. Can you translate those missing fields, please? Of course, anybody can help even not mentioned below.

By the way, we'd better maintain translators list somewhere.

abdurrahmanekr · 2017-10-15T10:04:45Z

Could you create a word list? Like #408

chinesedfan · 2017-10-15T10:42:19Z

@abdurrahmanekr The missing words are different for different languages. Can you comment directly? For example, tr requires them.

machour · 2017-10-15T11:00:31Z

@chinesedfan awesome work!

If we make this part of the travis check, could we define the guidelines that new translations should be added as "TRANSLATE_ME" instead of the english sentence or a poorly google translated string ?
This would make the translator life easier allowing him to directly spot untranslated strings.

Or we can have a second script running in pre-commit that does that automatically.

The translators list is already somehow available in CONTRIBUTORS.md. Translators have the translation key/emoji set

machour · 2017-10-15T11:03:54Z

And here are the missing translations for fr:

 noUsersFound: 'Aucun utilisateur trouvé :(',
noRepositoriesFound: 'Aucun dépôt trouvé :(',
starred: 'Favoris',
watching: 'Abonné',
watchers: 'Abonnés',

(@Antoine38660, watcher = abonné sounds ok to you?)

abdurrahmanekr · 2017-10-15T11:18:04Z

👍 @chinesedfan , here are the missing translations for TR:

noUsersFound: 'Kullanıcı Bulunamadı :('
noRepositoriesFound: 'Repository Bulunamadı'
watchers: 'İzleyenler'

chinesedfan · 2017-10-15T11:21:06Z

@machour Marking untranslated strings as TRANSLATE_ME really makes it easy to be discovered. But it may also make the app displays wired.

I know we can find translators in CONTRIBUTORS.md, but don't know who is good at which language.

@abdurrahmanekr Thanks again!

machour · 2017-10-15T11:37:57Z

@chinesedfan it makes the app display weird only when browsing it in translated mode using master. Which is mostly used by people who actually can translate the missing things they spot.

This would also allow to perform a quick check for releases: if there's a TRANSLATE_ME somewhere, we're not ready to release. (and if the translator is unavailable, then we can swap with an english string just for the release)

Seems like a fair trade-off when dealing with quality translations.

lex111

Russian translation

lex111 · 2017-10-15T12:46:13Z

src/locale/languages/ru.js

      searchMessage: 'Поиск {{type}}',
      repository: 'репозиториев',
      user: 'пользователей',
+      noUsersFound: 'No users found :(',


Пользователи не найдены :(

@lex111 Updated. Thank you!

lex111 · 2017-10-15T12:46:26Z

src/locale/languages/ru.js

      repository: 'репозиториев',
      user: 'пользователей',
+      noUsersFound: 'No users found :(',
+      noRepositoriesFound: 'No repositories found :(',


Репозитории не найдены :(

lex111 · 2017-10-15T12:47:02Z

src/locale/languages/ru.js

      applyLabelTitle: 'Добавить ярлык к этой задаче',
    },
+    comment: {
+      commentActions: 'Comment Actions',


Действия с комментарием

lex111 · 2017-10-15T12:47:15Z

src/locale/languages/ru.js

    },
+    comment: {
+      commentActions: 'Comment Actions',
+      editCommentTitle: 'Edit Comment',


Редактирование комментария

lex111 · 2017-10-15T12:47:20Z

src/locale/languages/ru.js

+    comment: {
+      commentActions: 'Comment Actions',
+      editCommentTitle: 'Edit Comment',
+      editAction: 'Edit',


Редактировать

lex111 · 2017-10-15T12:47:25Z

src/locale/languages/ru.js

+      commentActions: 'Comment Actions',
+      editCommentTitle: 'Edit Comment',
+      editAction: 'Edit',
+      deleteAction: 'Delete',


Удалить

peterblazejewicz · 2017-10-15T16:29:25Z

Hey guys, I need your help here. Can you translate those missing fields, please? Of course, anybody can help even not mentioned below.

@chinesedfan see #481

* fix(trans): Correct Polish translation wording - typos - changed wording to work better in UI context * feat(trans): New resource keys translation. See #478

tautf · 2017-10-16T05:46:58Z

src/locale/languages/de.js

      membersTitle: 'MITGLIEDER',
      descriptionTitle: 'BESCHREIBUNG',
    },
+    organizationActions: 'Organization Actions',


Organisation Aktionen

@tautf 👍

tautf · 2017-10-16T05:47:14Z

src/locale/languages/de.js

      openIssueSubTitle: '#{{number}} wude vor {{time}} von {{user}} geöffnet',
      closedIssueSubTitle:
        '#{{number}} von {{user}} wurde vor {{time}} geschlossen',
+      issueActions: 'Issue Actions',


Issue Aktionen

tautf · 2017-10-16T05:47:26Z

src/locale/languages/de.js

    abbreviations: {
      thousand: 't',
    },
+    openInBrowser: 'Open in Browser',


In Browser öffnen

Antoine38660 · 2017-10-16T12:10:31Z

@machour yes... watchers can be abonnés (but looks bizarre 😉)

jouderianjr · 2017-10-16T12:48:07Z

@chinesedfan using k in brazilian portuguese for thousand looks fine for me 😄

@nersoh @arthurdenner I know you guys are Brazilians also, what do you think about?

arthurdenner · 2017-10-16T12:52:21Z

I think it's fine as well. We usually use k to refer to thousands.

housseindjirdeh · 2017-10-16T14:35:53Z

Thank you all for this <3

@chinesedfan definitely would love to have a translations script check as part of our CI pipeline in travis.yml. Please feel free to put up a separate PR for that

chinesedfan · 2017-10-16T14:55:16Z

@housseindjirdeh I already integrated the check script in this PR. But if you persist, I can separate it out.

andrewda · 2017-10-17T02:09:39Z

.travis.yml

  - 'yarn'
 script:
  - yarn run eslint
+  - node __tests__/locales.test.js


Probably shouldn't do this here – this is going to cause a lot off issues with #407 and will end up just being moved out. Try to refactor this to the tests branch and make a PR there and it'll show up in #407. I can definitely help out in this area.

@andrewda I picked out commit 66b3228 and kept this PR focus on translations.

Do you have any suggestions for where I can put locales.test.js? I think __tests__ is not a good place, because it only contains jest testing files.

This reverts commit 66b3228.

chinesedfan · 2017-10-26T15:16:25Z

Can we merge this PR first? It is hard to find translators for eo/nl, and we used to keep words in English if no one can help. @housseindjirdeh @lex111

machour · 2017-10-26T15:36:55Z

+1 on moving forward with this and have Travis as a goal keeper for translations keys.

fix(trans): Make all translations contain same fields

17a46f9

chinesedfan added the discussion label Oct 15, 2017

chinesedfan force-pushed the fixtrans branch from 08851ee to dbe44b4 Compare October 15, 2017 07:32

chinesedfan added the tests label Oct 15, 2017

chinesedfan force-pushed the fixtrans branch from dbe44b4 to c48f432 Compare October 15, 2017 09:17

feat(test): Integrate locales check to travis ci

66b3228

chinesedfan force-pushed the fixtrans branch from c48f432 to 66b3228 Compare October 15, 2017 09:37

chinesedfan added the help wanted label Oct 15, 2017

fix(trans): Update as real words for fr and tr

f53654d

Jpfonseca mentioned this pull request Oct 15, 2017

Update pt.js with the new strings chinesedfan/git-point#1

Merged

fix(trans): Update pt.js with the new strings

5b9ade2

lex111 requested changes Oct 15, 2017

View reviewed changes

fix(trans): Update for ru

11fb92d

chinesedfan mentioned this pull request Oct 15, 2017

feat(translation): add Esperanto translation #471

Merged

peterblazejewicz added a commit to peterblazejewicz/git-point that referenced this pull request Oct 15, 2017

feat(trans): New resource keys translation. See gitpoint#478

ffacb24

peterblazejewicz mentioned this pull request Oct 15, 2017

fix(translation): polish typos, wording and new keys translated #481

Merged

Merge branch 'master' into fixtrans

e49416d

tautf reviewed Oct 16, 2017

View reviewed changes

fix(trans): Update for de

77e06d1

chinesedfan added 🏗️ work in progress and removed discussion labels Oct 16, 2017

andrewda reviewed Oct 17, 2017

View reviewed changes

Revert "feat(test): Integrate locales check to travis ci"

50ef0bd

This reverts commit 66b3228.

chinesedfan removed the tests label Oct 20, 2017

andrewda mentioned this pull request Oct 20, 2017

Add more tests! #518

Open

63 tasks

machour approved these changes Oct 26, 2017

View reviewed changes

chinesedfan merged commit 3714dc5 into gitpoint:master Oct 27, 2017

chinesedfan deleted the fixtrans branch October 27, 2017 10:58

chinesedfan mentioned this pull request Oct 27, 2017

test(locales): Add locales test #594

Merged

Conversation

chinesedfan commented Oct 15, 2017

Uh oh!

lex111 commented Oct 15, 2017

Uh oh!

chinesedfan commented Oct 15, 2017

Uh oh!

chinesedfan commented Oct 15, 2017

Uh oh!

lex111 commented Oct 15, 2017

Uh oh!

chinesedfan commented Oct 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdurrahmanekr commented Oct 15, 2017

Uh oh!

chinesedfan commented Oct 15, 2017

Uh oh!

machour commented Oct 15, 2017

Uh oh!

machour commented Oct 15, 2017

Uh oh!

abdurrahmanekr commented Oct 15, 2017

Uh oh!

chinesedfan commented Oct 15, 2017

Uh oh!

machour commented Oct 15, 2017

Uh oh!

lex111 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peterblazejewicz commented Oct 15, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Antoine38660 commented Oct 16, 2017

Uh oh!

jouderianjr commented Oct 16, 2017

Uh oh!

arthurdenner commented Oct 16, 2017

Uh oh!

housseindjirdeh commented Oct 16, 2017

Uh oh!

chinesedfan commented Oct 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinesedfan commented Oct 26, 2017

Uh oh!

machour commented Oct 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

chinesedfan commented Oct 15, 2017 •

edited

Loading