Skip to content

[openssh] upgrade openssh to v9.8p1#19994

Merged
roboquat merged 2 commits intomainfrom
pd/openssh
Jul 2, 2024
Merged

[openssh] upgrade openssh to v9.8p1#19994
roboquat merged 2 commits intomainfrom
pd/openssh

Conversation

@iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Jul 2, 2024

Description

Related Issue(s)

Fixes ENT-366

How to test

  1. start a workspace from this preview env
  2. try to connect workspace via ssh

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview

  • /werft with-preview

  • /werft with-large-vm

  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra

  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.

  • with-monitoring

  • with-integration-tests=ssh
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.

/hold

@kylos101
Copy link
Contributor

kylos101 commented Jul 2, 2024

@iQQBot I tried SSH'ing to a workspace using an access token in the preview environment, but it does not complete the connection. It hung at:

Authenticated to kylos101-gitpodcustomim-j4mddex9erg.ssh.ws-dev.pd-openssh.preview.gitpod-dev.com ([35.195.10.179]:22) using "none".
debug1: channel 0: new [client-session]
debug1: Entering interactive session.
debug1: pledge: filesystem

Authenticated to kylos101-dotfiles-my3f8czruff.ssh.ws-dev.pd-openssh.preview.gitpod-dev.com ([35.195.10.179]:22) using "none".
debug1: channel 0: new [client-session]
debug1: Entering interactive session.
debug1: pledge: filesystem

@iQQBot iQQBot marked this pull request as draft July 2, 2024 13:13
@roboquat roboquat added size/S and removed size/XS labels Jul 2, 2024
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Tried both access token and ssh keys, worked like a charm! 🚀 I also enabled ssh integration test

hold if @kylos101 want to double check

@iQQBot iQQBot marked this pull request as ready for review July 2, 2024 13:50
@kylos101
Copy link
Contributor

kylos101 commented Jul 2, 2024

Nice! Removing hold. 🙇

@roboquat roboquat merged commit 132070d into main Jul 2, 2024
@roboquat roboquat deleted the pd/openssh branch July 2, 2024 13:57
@akosyakov
Copy link
Member

akosyakov commented Jul 3, 2024

@iQQBot @mustard-mh I see that they have different change of patches: https://gitlab.alpinelinux.org/alpine/aports/-/commits/master/main/openssh?ref_type=heads

It seems to be misaligned with what we apply while building? Why don't we apply all patches and don't pin it to commit corresponding to version of openssh?

geropl pushed a commit that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants