Skip to content

Update SARIF output to return empty array if no results were found#530

Merged
zricethezav merged 1 commit intogitleaks:masterfrom
kiwiz:empty_sarif
Mar 5, 2021
Merged

Update SARIF output to return empty array if no results were found#530
zricethezav merged 1 commit intogitleaks:masterfrom
kiwiz:empty_sarif

Conversation

@kiwiz
Copy link
Contributor

@kiwiz kiwiz commented Feb 23, 2021

Description:

This is a bit pedantic, but according to the spec , the results object should be an empty array if the scanner ran successfully.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@zricethezav zricethezav merged commit bdcb9e3 into gitleaks:master Mar 5, 2021
@zricethezav
Copy link
Collaborator

@kiwiz noice

@kiwiz kiwiz deleted the empty_sarif branch April 26, 2021 20:47
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants