Skip to content

Always generate a report if --report is passed#508

Merged
zricethezav merged 1 commit intogitleaks:masterfrom
kiwiz:master
Jan 26, 2021
Merged

Always generate a report if --report is passed#508
zricethezav merged 1 commit intogitleaks:masterfrom
kiwiz:master

Conversation

@kiwiz
Copy link
Contributor

@kiwiz kiwiz commented Jan 19, 2021

Description:

Resolves #505

Checklist:

  • Does your PR pass tests? (I'm getting a testing.go:1038: race detected during execution of test that happens without any changes?)
  • Have you written new tests for your changes? (options_test.go is empty?)
  • Have you lint your code locally prior to submission?

@zricethezav
Copy link
Collaborator

@kiwiz I'm actually thinking the default behavior should be to always generate a report file if --report is set. Could you remove the always-report option and remove the return statement?

@kiwiz kiwiz changed the title Add option to always generate report Always generate a report if --report is passed Jan 22, 2021
@kiwiz
Copy link
Contributor Author

kiwiz commented Jan 22, 2021

That sounds even better! Fixed.

@zricethezav zricethezav merged commit c8e15c7 into gitleaks:master Jan 26, 2021
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Always generate SARIF output

2 participants