Fix dotgit regex again#507
Merged
zricethezav merged 2 commits intomasterfrom Jan 21, 2021
unknown repository
Merged
Conversation
Collaborator
|
@seb-elttam great catch! |
3 tasks
alayne222
pushed a commit
to alayne222/gitleaks
that referenced
this pull request
May 28, 2025
* fix dotgit regex again * Revert accidentally modified files Co-authored-by: Seb Elttam <seb@elttam.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Previous issues #482 and #486 did not fully fixe the dotgit regex bug.
To Reproduce
Check out a github repo into a local directory ending with
.git$ git clone https://github.com/zricethezav/gitleaks gitleaks.gitThen run gitleaks with
--no-git$ gitleaks -p ./gitleaks.git --no-gitNote that no leaks were found.
Expected behavior
Many leaks should be detected.
Env
This bug was confirmed on
zricethezav/gitleaks:v7.2.0which is currently the latest available version.Checklist: