Skip to content

default conc limit too high... whoops#12

Merged
zricethezav merged 1 commit intomasterfrom
fix/conc_factor
Feb 19, 2018
Merged

default conc limit too high... whoops#12
zricethezav merged 1 commit intomasterfrom
fix/conc_factor

Conversation

@zricethezav
Copy link
Collaborator

No description provided.

@zricethezav zricethezav merged commit 840e9e8 into master Feb 19, 2018
@zricethezav zricethezav deleted the fix/conc_factor branch February 19, 2018 20:35
sebastianpuka pushed a commit to sebastianpuka/Hacking--gitleaks that referenced this pull request Jan 23, 2024
default conc limit too high... whoops
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
default conc limit too high... whoops
mcode-app bot pushed a commit to anchan77/gitleaks that referenced this pull request Jan 23, 2026
Implemented version display and diagnostics commands for gitleaks Python implementation with full support for build-time version configuration:

Version Command:
- Added `gitleaks version` subcommand that displays "gitleaks version X.Y.Z"
- Updated `--version` flag to display "gitleaks version X.Y.Z" format (without comma)
- Implemented build-time version override via GITLEAKS_VERSION environment variable
- Version defaults to "0.1.0" from pyproject.toml but can be overridden at runtime
- Both `--version` flag and `version` subcommand produce identical output

Diagnostics Command:
- Added `gitleaks diagnostics` subcommand that displays comprehensive diagnostic information
- Shows runtime info: Python version, OS/platform, architecture
- Displays configuration details: config path, rule count, keyword count
- Shows allowlist statistics (paths, commits, regexes, stop words)
- Displays config settings like extends and title
- Shows GITLEAKS_* environment variables if set
- Supports --source option to specify directory for config file discovery
- Handles cases where no config file is found gracefully

Build-Time Version Configuration:
- Version can be set via GITLEAKS_VERSION environment variable at runtime
- Example: `GITLEAKS_VERSION=8.18.0 gitleaks --version` outputs "gitleaks version 8.18.0"
- This mimics Go's ldflags approach for setting version during build process
- Works consistently across all commands (--version, version, diagnostics)

Implementation Details:
- Created src/gitleaks/cli/version.py with version command
- Created src/gitleaks/cli/diagnostics.py with diagnostics command
- Updated src/gitleaks/__init__.py to support GITLEAKS_VERSION env var override
- Updated src/gitleaks/cli/__init__.py to export new commands
- Modified cli/common.py to customize version_option message format
- Both commands integrate with existing CLI infrastructure (logging, config loading)
- Follows same config discovery logic as other commands (--config flag, env vars, .gitleaks.toml)

Note on Diagnostics Scope:
The task specification intentionally redefined the diagnostics command to show configuration and environment information rather than performance profiling (which is what the Go source's diagnostics.go does). This implementation matches the task specification's acceptance criteria, providing users with useful troubleshooting information about their gitleaks setup.

All acceptance criteria from Task gitleaks#12 have been met and verified through comprehensive testing.

Milestone No.: 1
Task No.: 12
Task ID: 42
mcode-app bot pushed a commit to anchan77/gitleaks that referenced this pull request Jan 23, 2026
…eaks-milestone_1-task_12-8e9642

Implemented version display and diagnostics commands for gitleaks Python implementation with full support for build-time version configuration:

Version Command:
- Added `gitleaks version` subcommand that displays "gitleaks version X.Y.Z"
- Updated `--version` flag to display "gitleaks version X.Y.Z" format (without comma)
- Implemented build-time version override via GITLEAKS_VERSION environment variable
- Version defaults to "0.1.0" from pyproject.toml but can be overridden at runtime
- Both `--version` flag and `version` subcommand produce identical output

Diagnostics Command:
- Added `gitleaks diagnostics` subcommand that displays comprehensive diagnostic information
- Shows runtime info: Python version, OS/platform, architecture
- Displays configuration details: config path, rule count, keyword count
- Shows allowlist statistics (paths, commits, regexes, stop words)
- Displays config settings like extends and title
- Shows GITLEAKS_* environment variables if set
- Supports --source option to specify directory for config file discovery
- Handles cases where no config file is found gracefully

Build-Time Version Configuration:
- Version can be set via GITLEAKS_VERSION environment variable at runtime
- Example: `GITLEAKS_VERSION=8.18.0 gitleaks --version` outputs "gitleaks version 8.18.0"
- This mimics Go's ldflags approach for setting version during build process
- Works consistently across all commands (--version, version, diagnostics)

Implementation Details:
- Created src/gitleaks/cli/version.py with version command
- Created src/gitleaks/cli/diagnostics.py with diagnostics command
- Updated src/gitleaks/__init__.py to support GITLEAKS_VERSION env var override
- Updated src/gitleaks/cli/__init__.py to export new commands
- Modified cli/common.py to customize version_option message format
- Both commands integrate with existing CLI infrastructure (logging, config loading)
- Follows same config discovery logic as other commands (--config flag, env vars, .gitleaks.toml)

Note on Diagnostics Scope:
The task specification intentionally redefined the diagnostics command to show configuration and environment information rather than performance profiling (which is what the Go source's diagnostics.go does). This implementation matches the task specification's acceptance criteria, providing users with useful troubleshooting information about their gitleaks setup.

All acceptance criteria from Task gitleaks#12 have been met and verified through comprehensive testing.

Milestone No.: 1
Task No.: 12
Task ID: 42
mcode-app bot pushed a commit to anchan77/gitleaks that referenced this pull request Jan 23, 2026
…eaks-milestone_1-task_12-8e9642

Implemented version display and diagnostics commands for gitleaks Python implementation with full support for build-time version configuration:

Version Command:
- Added `gitleaks version` subcommand that displays "gitleaks version X.Y.Z"
- Updated `--version` flag to display "gitleaks version X.Y.Z" format (without comma)
- Implemented build-time version override via GITLEAKS_VERSION environment variable
- Version defaults to "0.1.0" from pyproject.toml but can be overridden at runtime
- Both `--version` flag and `version` subcommand produce identical output

Diagnostics Command:
- Added `gitleaks diagnostics` subcommand that displays comprehensive diagnostic information
- Shows runtime info: Python version, OS/platform, architecture
- Displays configuration details: config path, rule count, keyword count
- Shows allowlist statistics (paths, commits, regexes, stop words)
- Displays config settings like extends and title
- Shows GITLEAKS_* environment variables if set
- Supports --source option to specify directory for config file discovery
- Handles cases where no config file is found gracefully

Build-Time Version Configuration:
- Version can be set via GITLEAKS_VERSION environment variable at runtime
- Example: `GITLEAKS_VERSION=8.18.0 gitleaks --version` outputs "gitleaks version 8.18.0"
- This mimics Go's ldflags approach for setting version during build process
- Works consistently across all commands (--version, version, diagnostics)

Implementation Details:
- Created src/gitleaks/cli/version.py with version command
- Created src/gitleaks/cli/diagnostics.py with diagnostics command
- Updated src/gitleaks/__init__.py to support GITLEAKS_VERSION env var override
- Updated src/gitleaks/cli/__init__.py to export new commands
- Modified cli/common.py to customize version_option message format
- Both commands integrate with existing CLI infrastructure (logging, config loading)
- Follows same config discovery logic as other commands (--config flag, env vars, .gitleaks.toml)

Note on Diagnostics Scope:
The task specification intentionally redefined the diagnostics command to show configuration and environment information rather than performance profiling (which is what the Go source's diagnostics.go does). This implementation matches the task specification's acceptance criteria, providing users with useful troubleshooting information about their gitleaks setup.

All acceptance criteria from Task gitleaks#12 have been met and verified through comprehensive testing.

Milestone No.: 1
Task No.: 12
Task ID: 42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant