Skip to content

add reviewers related fields to MergeRequestEvent webhook event#916

Merged
jmini merged 4 commits into
gitlab4j:masterfrom
mifitous:add-missing-reviewers-to-MergeRequestEvent
Apr 4, 2023
Merged

add reviewers related fields to MergeRequestEvent webhook event#916
jmini merged 4 commits into
gitlab4j:masterfrom
mifitous:add-missing-reviewers-to-MergeRequestEvent

Conversation

@mifitous

@mifitous mifitous commented Feb 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR will add the missing reviewers fields to the MergeRequestEvent

@mifitous

mifitous commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

Hi @jabby
Can you please review and trigger checks?
Merci beaucoup

@mifitous

mifitous commented Feb 17, 2023

Copy link
Copy Markdown
Contributor Author

@gmessner @tubbynl @krische @PhilippeVienne @lamdav
Hello dear gentlemen

Can someone of you please review it? It is blocking us from delivering another fix in a Jenkins plug-in

Sincerely,
@mifitous

@mifitous

mifitous commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

Hi @bwaldvogel
Maybe you can review it please?

@tabilzad

tabilzad commented Feb 20, 2023

Copy link
Copy Markdown

duplicate 879

@mifitous

mifitous commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

duplicate 879

Hi @tabilzad
This one has passed all tests on my machine, so wondering if we can close #879 and ack this one please?

@tabilzad

tabilzad commented Feb 20, 2023 •
edited
Loading

Copy link
Copy Markdown

@mifitous Both PRs have identical file changes so the pipeline test failures cant be PR related. I'll let the maintainers decide, but it's obviously not a great practice to pollute the PR log with identical PRs just because older ones don't get maintainers' attention.

@mifitous

mifitous commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

@mifitous Both PRs have identical file changes so the pipeline test failures cant be PR related. I'll let the maintainers decide, but it's obviously not a great practice to pollute the PR log with identical PRs just because older ones don't get maintainers' attention.

@tabilzad : I see #879 is opened for already more than 3 month, and no maintainer even reacted. I'm fine for having it either way, but it seems we may need to envisage adding more active maintainers to this repo...

@mifitous

mifitous commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

Hi @jabby
Can you please review and trigger checks?
Merci beaucoup

@jmini

jmini commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

In my opinion the merge-request-event.json should be updated so that it has the new attribute reviewers.

Check "Payload example" in Merge request events

jmini
jmini requested changes Mar 16, 2023
View reviewed changes

@jmini jmini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the JSON file corresponding to this change should be updated as well.

@mifitous

mifitous commented Mar 17, 2023

Copy link
Copy Markdown
Contributor Author

Hi @jmini
Will have a look, Thank you

@mifitous mifitous force-pushed the add-missing-reviewers-to-MergeRequestEvent branch from 1fb0272 to e4d13ac Compare March 21, 2023 12:18
@mifitous

mifitous commented Apr 2, 2023

Copy link
Copy Markdown
Contributor Author

I think the JSON file corresponding to this change should be updated as well.

Hi @jmini
updated

@jmini

jmini commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

I have updated the example JSON one more time, because it seems that we are not supporting all the fields you added (can be done in a follow up step)

@jmini jmini merged commit dc0f9f2 into gitlab4j:master Apr 4, 2023
This was referenced Apr 4, 2023
Closed
Merged
@mifitous mifitous deleted the add-missing-reviewers-to-MergeRequestEvent branch April 4, 2023 11:48
@mifitous mifitous mentioned this pull request Apr 4, 2023
Closed
6 tasks
@mifitous

mifitous commented Apr 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @jabby / @gmessner
Can you please trigger a new release to get this PR delivered? #945

@jmini jmini mentioned this pull request Apr 13, 2023
Merged
@mifitous mifitous restored the add-missing-reviewers-to-MergeRequestEvent branch April 17, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmini jmini jmini approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mifitous @tabilzad @jmini