Skip to content

add missing reviewers related fields to MergeRequestEvent webhook event#879

Closed
tabilzad wants to merge 2 commits into
gitlab4j:masterfrom
tabilzad:master
Closed

add missing reviewers related fields to MergeRequestEvent webhook event#879
tabilzad wants to merge 2 commits into
gitlab4j:masterfrom
tabilzad:master

Conversation

@tabilzad

@tabilzad tabilzad commented Nov 30, 2022

Copy link
Copy Markdown

This PR will add the missing reviewers fields to the MergeRequestEvent

  • List<Reviewer> reviewers at top level of MergeRequestEvent.java
  • List<Long> reviewerIds to ObjectAttributes of MergeRequestEvent.java

https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html#merge-request-events

@mifitous

mifitous commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

Hi @tabilzad
Any chance we can merge this one?
It is blocking me to provide support to https://github.com/jenkinsci/gitlab-branch-source-plugin
Thanks

@tabilzad

Copy link
Copy Markdown
Author

@jabby could u assist with this one, not sure why the pipeline is failing for testExportDownloadAndImport. The PR is just adding new fields to data classes

@jmini

jmini commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

In my opinion this can be closed after the merge of #916.

If not, feel free to re-open…

@jmini jmini closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants