Skip to content

Stops getting new vscode GitHub sessions, creates new sessions via GKDev#4897

Merged
sergeibbb merged 4 commits intomainfrom
4881-stop-getting-new-vscode-github-sessions
Jan 27, 2026
Merged

Stops getting new vscode GitHub sessions, creates new sessions via GKDev#4897
sergeibbb merged 4 commits intomainfrom
4881-stop-getting-new-vscode-github-sessions

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jan 19, 2026

Description

Implements #4881

Syncs local session when its cloud version is connected

We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.

Stops skipping syncing disconnected integrations

Disconnected integrations stopped being synced because the disconnect
call returned false.
Now we skip on failure only.

Stops requesting built-in VSCode new session retrieval

Only requests for existion sessions. Never asks to issue a new one.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb added this to the 17.10 milestone Jan 19, 2026
@sergeibbb sergeibbb linked an issue Jan 19, 2026 that may be closed by this pull request
10 tasks
sergeibbb added a commit that referenced this pull request Jan 19, 2026
…sions

Removes redundant logic that conditionally re-fetched a session in
VSCode if `forceNewSession` was true.

If there is no an existing available for GitLens session in VSCode, then
always go to the GKDev flow.
(#4881, #4897)
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 7392330 to 1e7af7c Compare January 19, 2026 14:48
@augmentcode
Copy link

augmentcode bot commented Jan 19, 2026

🤖 Augment PR Summary

Summary: Updates GitHub authentication to avoid creating new VS Code built-in GitHub sessions and to prefer GitKraken Dev (cloud) sessions for connecting.

Changes:

  • Resolves GitHub sessions via the cloud provider first, then falls back to a silent reuse of an existing VS Code built-in session
  • Adjusts cloud re-auth handling to only abort on an actual disconnect failure (not just “already disconnected” cases)
  • Allows cloud sync to replace existing non-cloud/local sessions when a cloud connection is detected
  • Updates the changelog for the reauthenticate flow fix (4879: Remove the flow of forcing to create VSCode's GitHub authentication #4881)

Technical Notes: New connections should flow through GKDev; VS Code built-in sessions are only reused if already present.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 1e7af7c to c8fbf7d Compare January 19, 2026 15:51
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from c8fbf7d to 5885ee2 Compare January 19, 2026 16:03
@sergeibbb sergeibbb marked this pull request as draft January 19, 2026 19:01
sergeibbb added a commit that referenced this pull request Jan 20, 2026
…sions

Removes redundant logic that conditionally re-fetched a session in
VSCode if `forceNewSession` was true.

If there is no an existing available for GitLens session in VSCode, then
always go to the GKDev flow.
(#4881, #4897)
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 5885ee2 to 80eeff0 Compare January 20, 2026 19:47
sergeibbb added a commit that referenced this pull request Jan 21, 2026
Only requests for existion sessions. Never asks to issue a new one.
(#4881, #4897)
sergeibbb added a commit that referenced this pull request Jan 21, 2026
Disconnected integrations stopped being synced because the `disconnect`
call returned `false`.
Now we skip on failure only.
(#4881, #4897)
sergeibbb added a commit that referenced this pull request Jan 21, 2026
We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.
(#4881, #4897)
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 80eeff0 to 1b315b7 Compare January 21, 2026 14:27
@sergeibbb sergeibbb marked this pull request as ready for review January 21, 2026 14:27
sergeibbb added a commit that referenced this pull request Jan 21, 2026
We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.
(#4881, #4897)
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 1b315b7 to 5ea3f71 Compare January 21, 2026 14:29
Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

sergeibbb added a commit that referenced this pull request Jan 21, 2026
Disconnected integrations stopped being synced because the `disconnect`
call returned `false`.
Now we skip on failure only.
(#4881, #4897)
sergeibbb added a commit that referenced this pull request Jan 21, 2026
We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.
(#4881, #4897)
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 5ea3f71 to b2f7415 Compare January 21, 2026 14:36
@sergeibbb sergeibbb requested a review from eamodio January 21, 2026 14:37
sergeibbb added a commit that referenced this pull request Jan 23, 2026
We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.
(#4881, #4897)
@sergeibbb sergeibbb requested review from eamodio and ramin-t January 23, 2026 17:12
@sergeibbb
Copy link
Member Author

@eamodio, @axosoft-ramint

I'm pushing it as a fix to the reported problem and try to not change a lot the rest of the current behavior. I suggest that the further improvements should go in #4882.

Behavioral changes of the current PR and verification steps are described in the issue #4881.

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

sergeibbb added a commit that referenced this pull request Jan 23, 2026
Only requests for existion sessions. Never asks to issue a new one.
(#4881, #4897)
sergeibbb added a commit that referenced this pull request Jan 23, 2026
Disconnected integrations stopped being synced because the `disconnect`
call returned `false`.
Now we skip on failure only.
(#4881, #4897)
sergeibbb added a commit that referenced this pull request Jan 23, 2026
We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.
(#4881, #4897)
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 73dbe7d to 1f50f92 Compare January 23, 2026 17:50
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 1f50f92 to 327d86e Compare January 23, 2026 17:51
Copy link
Contributor

@ramin-t ramin-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a long while since I've touched integrations so I'm not sure what could regress or what depends on the logic being touched, but it seems harmless enough to switch priority to the cloud session over the local.

I would suggest testing github.dev/vscode.dev and other web interfaces and making sure nothing broke with pulling the built-in github sessions there, but otherwise LGTM

sergeibbb added a commit that referenced this pull request Jan 26, 2026
Only requests for existion sessions. Never asks to issue a new one.
(#4881, #4897)
sergeibbb added a commit that referenced this pull request Jan 26, 2026
Disconnected integrations stopped being synced because the `disconnect`
call returned `false`.
Now we skip on failure only.
(#4881, #4897)
sergeibbb added a commit that referenced this pull request Jan 26, 2026
We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.
(#4881, #4897)
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 327d86e to 6f10f0c Compare January 26, 2026 10:43
Only requests for existion sessions. Never asks to issue a new one.
(#4881, #4897)
Disconnected integrations stopped being synced because the `disconnect`
call returned `false`.
Now we skip on failure only.
(#4881, #4897)
We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.
(#4881, #4897)
@sergeibbb sergeibbb force-pushed the 4881-stop-getting-new-vscode-github-sessions branch from 6f10f0c to c45f60d Compare January 27, 2026 11:56
@sergeibbb
Copy link
Member Author

sergeibbb commented Jan 27, 2026

@axosoft-ramint

I would suggest testing github.dev/vscode.dev and other web interfaces and making sure nothing broke with pulling the built-in github sessions there, but otherwise LGTM

Yes, I tested it on vscode.dev. Testing on web environment is reflected in Verification steps. I'm merging.

@sergeibbb sergeibbb merged commit db967ad into main Jan 27, 2026
6 checks passed
sergeibbb added a commit that referenced this pull request Jan 27, 2026
Only requests for existion sessions. Never asks to issue a new one.
(#4881, #4897)
sergeibbb added a commit that referenced this pull request Jan 27, 2026
Disconnected integrations stopped being synced because the `disconnect`
call returned `false`.
Now we skip on failure only.
(#4881, #4897)
sergeibbb added a commit that referenced this pull request Jan 27, 2026
We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.
(#4881, #4897)
@sergeibbb sergeibbb deleted the 4881-stop-getting-new-vscode-github-sessions branch January 27, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4879: Remove the flow of forcing to create VSCode's GitHub authentication

2 participants