Conversation
7392330 to
1e7af7c
Compare
🤖 Augment PR SummarySummary: Updates GitHub authentication to avoid creating new VS Code built-in GitHub sessions and to prefer GitKraken Dev (cloud) sessions for connecting. Changes:
Technical Notes: New connections should flow through GKDev; VS Code built-in sessions are only reused if already present. 🤖 Was this summary useful? React with 👍 or 👎 |
1e7af7c to
c8fbf7d
Compare
c8fbf7d to
5885ee2
Compare
5885ee2 to
80eeff0
Compare
80eeff0 to
1b315b7
Compare
1b315b7 to
5ea3f71
Compare
5ea3f71 to
b2f7415
Compare
73dbe7d to
1f50f92
Compare
1f50f92 to
327d86e
Compare
ramin-t
left a comment
There was a problem hiding this comment.
It's been a long while since I've touched integrations so I'm not sure what could regress or what depends on the logic being touched, but it seems harmless enough to switch priority to the cloud session over the local.
I would suggest testing github.dev/vscode.dev and other web interfaces and making sure nothing broke with pulling the built-in github sessions there, but otherwise LGTM
327d86e to
6f10f0c
Compare
6f10f0c to
c45f60d
Compare
|
@axosoft-ramint
Yes, I tested it on vscode.dev. Testing on web environment is reflected in Verification steps. I'm merging. |
Description
Implements #4881
Syncs local session when its cloud version is connected
We used to skip local (non-cloud) sessions from syncing to preserve
them. Unfortunately it causes invalid local sessions to persist.
Now it always syncronizes a cloud session if it's connected on GKDev.
Stops skipping syncing disconnected integrations
Disconnected integrations stopped being synced because the
disconnectcall returned
false.Now we skip on failure only.
Stops requesting built-in VSCode new session retrieval
Only requests for existion sessions. Never asks to issue a new one.
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses