Skip to content

Tracks hover-sourced actions in telemetry#4765

Merged
sergeibbb merged 5 commits intomainfrom
PLG-139-hover-event-source
Dec 3, 2025
Merged

Tracks hover-sourced actions in telemetry#4765
sergeibbb merged 5 commits intomainfrom
PLG-139-hover-event-source

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Nov 28, 2025

Description

Solves: #4764

  1. Adds source to hover actions
    • editor:hover for different types of editor hovers
    • statusbar:hover for the hover of statusbar.
    • view:hover for hovers on views.
  2. Uses detail= attribute to distinguish same types of events triggered by different elements of the hover.
  3. Converts autolinks from simple markdown links to actions
  4. Additionally solves an old "TODO" on the graph view, to user an action for opening issues.

Main changes are in:

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

sergeibbb added a commit that referenced this pull request Nov 28, 2025
@sergeibbb sergeibbb force-pushed the PLG-139-hover-event-source branch from 2640d03 to 16383f3 Compare November 28, 2025 16:53
sergeibbb added a commit that referenced this pull request Nov 28, 2025
It lets us track the source of event.
(#4764, #4765, PLG-139)
@sergeibbb sergeibbb linked an issue Nov 28, 2025 that may be closed by this pull request
@sergeibbb sergeibbb changed the title PLG 139 hover event source Track hover-sourced actions in telemetry Nov 28, 2025
@sergeibbb sergeibbb changed the title Track hover-sourced actions in telemetry Tracks hover-sourced actions in telemetry Nov 28, 2025
@sergeibbb sergeibbb requested review from eamodio and ramin-t November 28, 2025 16:55
@d13 d13 self-requested a review December 2, 2025 16:24
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that we talked about instead changing the command names to use :{source} like we do with :graph :view, etc. See commands like gitlens.ai.explainBranch for reference.

sergeibbb added a commit that referenced this pull request Dec 3, 2025
sergeibbb added a commit that referenced this pull request Dec 3, 2025
It lets us track the source of event.
(#4764, #4765, PLG-139)
@sergeibbb sergeibbb force-pushed the PLG-139-hover-event-source branch from 16383f3 to dd0e930 Compare December 3, 2025 17:15
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok after some discussion, we'll leave this as-is for now.

@sergeibbb sergeibbb force-pushed the PLG-139-hover-event-source branch from dd0e930 to 2584fa3 Compare December 3, 2025 19:38
@sergeibbb sergeibbb merged commit 08a3ef2 into main Dec 3, 2025
4 checks passed
sergeibbb added a commit that referenced this pull request Dec 3, 2025
sergeibbb added a commit that referenced this pull request Dec 3, 2025
It lets us track the source of event.
(#4764, #4765, PLG-139)
@sergeibbb sergeibbb deleted the PLG-139-hover-event-source branch December 3, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track hover-sourced actions in telemetry (PLG-139)

2 participants