Tracks hover-sourced actions in telemetry#4765
Merged
Conversation
sergeibbb
added a commit
that referenced
this pull request
Nov 28, 2025
2640d03 to
16383f3
Compare
sergeibbb
added a commit
that referenced
this pull request
Nov 28, 2025
sergeibbb
added a commit
that referenced
this pull request
Nov 28, 2025
d13
requested changes
Dec 3, 2025
sergeibbb
added a commit
that referenced
this pull request
Dec 3, 2025
16383f3 to
dd0e930
Compare
sergeibbb
added a commit
that referenced
this pull request
Dec 3, 2025
sergeibbb
added a commit
that referenced
this pull request
Dec 3, 2025
d13
approved these changes
Dec 3, 2025
Member
d13
left a comment
There was a problem hiding this comment.
Ok after some discussion, we'll leave this as-is for now.
dd0e930 to
2584fa3
Compare
sergeibbb
added a commit
that referenced
this pull request
Dec 3, 2025
sergeibbb
added a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves: #4764
sourceto hover actionseditor:hoverfor different types of editor hoversstatusbar:hoverfor the hover of statusbar.view:hoverfor hovers on views.detail=attribute to distinguish same types of events triggered by different elements of the hover.Main changes are in:
view:hoverandstatusbar:hover,sourceas a new field ofthis._optionsand passes all over the commands. I've replaced hardcoded usage of theeditor:viewsource with the provided value.fromTemplate,fromTemplateAsync,fromTemplateCoreAsyncsourceas parameter. So all its consumers need to pass some source to it.sourceto telemetry events.openUrlwith theopenIssuecommand.Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses