Skip to content

AI feedback disposable provider#4518

Merged
sergeibbb merged 3 commits intomainfrom
4449-feedback-provider
Aug 5, 2025
Merged

AI feedback disposable provider#4518
sergeibbb merged 3 commits intomainfrom
4449-feedback-provider

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jul 31, 2025

Description

This is a follow-up of #4449 and #4479

It wraps static ai-feedback related values to a disposable provided linked to the container.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb
Copy link
Member Author

sergeibbb commented Jul 31, 2025

@axosoft-ramint: I'm having a hard time parsing the need for this between all of the linked issues and PRs, nor do I know how to test it, so I will defer to @eamodio 's review on this one, unless you can give me a full rundown/explanation as someone who hasn't been involved with this work @sergeibbb .

I just thought that since the implementation is stateful it might be worth to attach it to the container as a stateful class.
@axosoft-ramint @ericf-axosoft

@sergeibbb sergeibbb changed the title 4449 feedback provider AI feedback disposable provider Jul 31, 2025
This was referenced Jul 31, 2025
Merged
Merged
@sergeibbb sergeibbb changed the base branch from main to 4449-feedback-on-changelog July 31, 2025 12:22
@sergeibbb sergeibbb linked an issue Jul 31, 2025 that may be closed by this pull request
Capture sentiment feedback about AI feature effectiveness #4449
Closed
4 tasks
@sergeibbb sergeibbb force-pushed the 4449-feedback-on-changelog branch 2 times, most recently from 91f9b4a to 13055df Compare July 31, 2025 12:41
sergeibbb added a commit that referenced this pull request Jul 31, 2025
@sergeibbb
Refactors AI feedback context handling for changelog docs
8b1c60f 
Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4518)
@sergeibbb sergeibbb force-pushed the 4449-feedback-provider branch from 9cf1770 to 545bec1 Compare July 31, 2025 13:31
sergeibbb added a commit that referenced this pull request Jul 31, 2025
@sergeibbb
Moves AI feedback URI state handling to provider
c0b9461 
Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4518)
sergeibbb added a commit that referenced this pull request Jul 31, 2025
@sergeibbb
Moves AI feedback context management into provider
545bec1 
(#4449, #4518)
dzp5103

This comment was marked as spam.

Sign in to view

@gitkraken gitkraken deleted a comment from dzp5103 Aug 4, 2025
@sergeibbb sergeibbb force-pushed the 4449-feedback-on-changelog branch from 13055df to 5fd6a0f Compare August 5, 2025 15:45
sergeibbb added a commit that referenced this pull request Aug 5, 2025
@sergeibbb
Refactors AI feedback context handling for changelog docs
b7cd08d 
Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4518)
sergeibbb added a commit that referenced this pull request Aug 5, 2025
@sergeibbb
Moves AI feedback URI state handling to provider
01e6442 
Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4518)
@sergeibbb sergeibbb force-pushed the 4449-feedback-provider branch from 545bec1 to b2e7cd7 Compare August 5, 2025 15:47
sergeibbb added a commit that referenced this pull request Aug 5, 2025
@sergeibbb
Moves AI feedback context management into provider
b2e7cd7 
(#4449, #4518)
@sergeibbb sergeibbb force-pushed the 4449-feedback-on-changelog branch from 5fd6a0f to 621283b Compare August 5, 2025 16:09
Base automatically changed from 4449-feedback-on-changelog to main August 5, 2025 16:11
@sergeibbb
Refactors AI feedback context handling for changelog docs
adf5d5f 
Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4518)
@sergeibbb
Moves AI feedback URI state handling to provider
b380676 
Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4518)
@sergeibbb
Moves AI feedback context management into provider
55d5d19 
(#4449, #4518)
@sergeibbb sergeibbb force-pushed the 4449-feedback-provider branch from b2e7cd7 to 55d5d19 Compare August 5, 2025 16:14
@sergeibbb sergeibbb merged commit bedf8a5 into main Aug 5, 2025
3 checks passed
sergeibbb added a commit that referenced this pull request Aug 5, 2025
@sergeibbb
Refactors AI feedback context handling for changelog docs
82b4b9c 
Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4518)
sergeibbb added a commit that referenced this pull request Aug 5, 2025
@sergeibbb
Moves AI feedback URI state handling to provider
90e8af5 
Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4518)
@sergeibbb sergeibbb deleted the 4449-feedback-provider branch August 5, 2025 16:18
wlnxing pushed a commit to wlnxing/vscode-gitlens that referenced this pull request Aug 19, 2025
@sergeibbb @wlnxing
Refactors AI feedback context handling for changelog docs
360c039 
Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(gitkraken#4449, gitkraken#4518)
wlnxing pushed a commit to wlnxing/vscode-gitlens that referenced this pull request Aug 19, 2025
@sergeibbb @wlnxing
Moves AI feedback URI state handling to provider
aebaa04 
Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(gitkraken#4449, gitkraken#4518)
wlnxing pushed a commit to wlnxing/vscode-gitlens that referenced this pull request Aug 19, 2025
@sergeibbb @wlnxing
Moves AI feedback context management into provider
c8c150d 
(gitkraken#4449, gitkraken#4518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d13 d13 d13 approved these changes

+1 more reviewer

@dzp5103 dzp5103 dzp5103 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Capture sentiment feedback about AI feature effectiveness

3 participants

@sergeibbb @d13 @dzp5103