Skip to content

Modify the "Create Pull Request" button#4347

Merged
sergeibbb merged 4 commits intomainfrom
4332-modify-create-pr-button
Jun 5, 2025
Merged

Modify the "Create Pull Request" button#4347
sergeibbb merged 4 commits intomainfrom
4332-modify-create-pr-button

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented May 30, 2025 •
edited
Loading

Description

Resolves part of #4332.

  • combines the "Create Pull Request" and "Create with AI" buttons into a split button
  • adds the pull request icon to the primary button
  • when the ✨ button is hovered, display the current tooltip: "Create a Pull Request with AI (Preview)"

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb linked an issue May 30, 2025 that may be closed by this pull request
Simplify work item section of Home View #4332
Closed
14 tasks
sergeibbb added a commit that referenced this pull request May 30, 2025
@sergeibbb
Combines "Create PR" and "Create with AI" buttons into a split button
d79bee6 
(#4332, #4347)
@sergeibbb sergeibbb force-pushed the 4332-modify-create-pr-button branch from 3c3d9e3 to e54a650 Compare May 30, 2025 16:17
sergeibbb added a commit that referenced this pull request May 30, 2025
@sergeibbb
Adds the pull request icon to the primary "Create PR" button
fe4a812 
(#4332, #4347)
sergeibbb added a commit that referenced this pull request May 30, 2025
@sergeibbb
Mentions "Create PR" button changes in the CHANGELOG
e54a650 
(#4330, #4347)
@sergeibbb sergeibbb requested a review from d13 May 30, 2025 16:18
sergeibbb added a commit that referenced this pull request Jun 2, 2025
@sergeibbb
Combines "Create PR" and "Create with AI" buttons into a split button
303f003 
(#4332, #4347)
sergeibbb added a commit that referenced this pull request Jun 2, 2025
@sergeibbb
Adds the pull request icon to the primary "Create PR" button
3946340 
(#4332, #4347)
@sergeibbb sergeibbb force-pushed the 4332-modify-create-pr-button branch from e54a650 to f2e02a8 Compare June 2, 2025 10:50
sergeibbb added a commit that referenced this pull request Jun 2, 2025
@sergeibbb
Mentions "Create PR" button changes in the CHANGELOG
f2e02a8 
(#4330, #4347)
@sergeibbb sergeibbb mentioned this pull request Jun 2, 2025
Closed
14 tasks
d13
d13 requested changes Jun 2, 2025
View reviewed changes
src/webviews/apps/plus/home/components/branch-card.ts Outdated
<code-icon
class="branch-item__is-wide"
icon="sparkle"
slot="prefix"
Copy link
Member

@d13 d13 Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the slot="prefix"

Suggested change
slot="prefix"

Copy link
Member Author

@sergeibbb sergeibbb Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d13
done f1ea3a2

sergeibbb added a commit that referenced this pull request Jun 3, 2025
@sergeibbb
Combines "Create PR" and "Create with AI" buttons into a split button
e528751 
(#4332, #4347)
sergeibbb added a commit that referenced this pull request Jun 3, 2025
@sergeibbb
Adds the pull request icon to the primary "Create PR" button
5a98751 
(#4332, #4347)
@sergeibbb sergeibbb force-pushed the 4332-modify-create-pr-button branch from f2e02a8 to f1ea3a2 Compare June 3, 2025 12:05
sergeibbb added a commit that referenced this pull request Jun 3, 2025
@sergeibbb
Mentions "Create PR" button changes in the CHANGELOG
b4fd5ed 
(#4332, #4347)
sergeibbb added a commit that referenced this pull request Jun 3, 2025
@sergeibbb
Removes media condition on AI-PR button styling
f1ea3a2 
(#4332, #4347)
d13
d13 approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a conflict resolved

@sergeibbb sergeibbb force-pushed the 4332-modify-create-pr-button branch from f1ea3a2 to 02d971e Compare June 5, 2025 16:18
@sergeibbb sergeibbb merged commit ce1d2d9 into main Jun 5, 2025
3 checks passed
sergeibbb added a commit that referenced this pull request Jun 5, 2025
@sergeibbb
Combines "Create PR" and "Create with AI" buttons into a split button
8e395f1 
(#4332, #4347)
sergeibbb added a commit that referenced this pull request Jun 5, 2025
@sergeibbb
Adds the pull request icon to the primary "Create PR" button
7154157 
(#4332, #4347)
sergeibbb added a commit that referenced this pull request Jun 5, 2025
@sergeibbb
Mentions "Create PR" button changes in the CHANGELOG
1b9fac7 
(#4332, #4347)
@sergeibbb sergeibbb deleted the 4332-modify-create-pr-button branch June 5, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d13 d13 d13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simplify work item section of Home View

2 participants

@sergeibbb @d13