Skip to content

Implements getPullRequestForCommit and getAccountForCommit for Azure and Bitbucket#4243

Merged
ramin-t merged 9 commits intomainfrom
4192-get-pr-for-commit
Apr 30, 2025
Merged

Implements getPullRequestForCommit and getAccountForCommit for Azure and Bitbucket#4243
ramin-t merged 9 commits intomainfrom
4192-get-pr-for-commit

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Apr 22, 2025 •
edited
Loading

Description

Implements getPullRequestForCommit and getAccountForCommit for Azure and Bitbucket.
Solves #4192

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb linked an issue Apr 22, 2025 that may be closed by this pull request
Get "associated PR for commit" working on all providers that don't have it #4192
Closed
7 tasks
@sergeibbb sergeibbb mentioned this pull request Apr 22, 2025
Closed
7 tasks
sergeibbb added a commit that referenced this pull request Apr 22, 2025
@sergeibbb
Fixes owner, project and repo retreival in Azure RemoteProvider for VSTS
c98e1ec 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 22, 2025
@sergeibbb
Implements getPullRequestForCommit for AzureDevOps
58edc29 
(#4192, #4243)
@sergeibbb sergeibbb force-pushed the 4192-get-pr-for-commit branch from 27e89a7 to 0a19579 Compare April 22, 2025 12:58
sergeibbb added a commit that referenced this pull request Apr 22, 2025
@sergeibbb
Implements gitPullRequestForCommit for Bitbucket
f10f500 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 22, 2025
@sergeibbb
Implements getPullRequestForCommit for Bitbucket DataCenter
e16c481 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 22, 2025
@sergeibbb
Implements getAccountForCommit for Bitbucket
b531500 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 22, 2025
@sergeibbb
Implements getAccountForCommit for Bitbucket DataCenter
d7e376b 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 22, 2025
@sergeibbb
Implements getAccountForCommit for AzureDevOps
aa14a3a 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 22, 2025
@sergeibbb
Adds Bitbucket PR commit links app not installed warning
0a19579 
Displays a warning message when Bitbucket PR commit links are unavailable.
This informs the user about the need to install the Bitbucket app for their commits.
(#4192, #4243)
@sergeibbb sergeibbb requested review from eamodio and ramin-t April 22, 2025 13:06
sergeibbb added a commit that referenced this pull request Apr 22, 2025
@sergeibbb
Describes fixes in Changelog (#4192, #4243)
74f9920
@d13 d13 self-requested a review April 23, 2025 15:31
ramin-t
ramin-t reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@ramin-t ramin-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I'm not able to get this to work. I'm getting a bunch of errors with Azure DevOps that say invalid response body...unexpected token <.

Screenshot:

image

But I think it might be some issue with the Azure DevOps integraiton outside of this PR, because it is affecting other calls as well.

Will investigate, and re-test once I've addressed it. In the meantime, here are a few tiny comments.

@d13
Copy link
Member

d13 commented Apr 24, 2025

Unfortunately, I'm not able to get this to work. I'm getting a bunch of errors with Azure DevOps that say invalid response body...unexpected token <.

Screenshot:

image

But I think it might be some issue with the Azure DevOps integraiton outside of this PR, because it is affecting other calls as well.

Will investigate, and re-test once I've addressed it. In the meantime, here are a few tiny comments.

Looks like the response returned HTML instead of JSON

@sergeibbb
Copy link
Member Author

sergeibbb commented Apr 24, 2025

@axosoft-ramint @d13
Thank you! I'll look at it

sergeibbb added a commit that referenced this pull request Apr 25, 2025
@sergeibbb
Fixes owner, project and repo retreival in Azure RemoteProvider for VSTS
e438565 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 25, 2025
@sergeibbb
Implements getPullRequestForCommit for AzureDevOps
e4692ce 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 25, 2025
@sergeibbb
Implements gitPullRequestForCommit for Bitbucket
358c198 
(#4192, #4243)
@sergeibbb sergeibbb force-pushed the 4192-get-pr-for-commit branch from 74f9920 to e8fdaa5 Compare April 25, 2025 14:47
sergeibbb added a commit that referenced this pull request Apr 25, 2025
@sergeibbb
Implements getPullRequestForCommit for Bitbucket DataCenter
1363f50 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 25, 2025
@sergeibbb
Implements getAccountForCommit for Bitbucket
7f93076 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 25, 2025
@sergeibbb
Implements getAccountForCommit for Bitbucket DataCenter
e4f5410 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 25, 2025
@sergeibbb
Implements getAccountForCommit for AzureDevOps
d54a782 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 25, 2025
@sergeibbb
Adds Bitbucket PR commit links app not installed warning
a077fa9 
Displays a warning message when Bitbucket PR commit links are unavailable.
This informs the user about the need to install the Bitbucket app for their commits.
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 25, 2025
@sergeibbb
Describes fixes in Changelog (#4192, #4243)
e8fdaa5
sergeibbb added a commit that referenced this pull request Apr 28, 2025
@sergeibbb
Fixes owner, project and repo retreival in Azure RemoteProvider for VSTS
9f7562f 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 28, 2025
@sergeibbb
Implements getPullRequestForCommit for AzureDevOps
51f1fbd 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 29, 2025
@sergeibbb
Adds Bitbucket PR commit links app not installed warning
b66e1f4 
Displays a warning message when Bitbucket PR commit links are unavailable.
This informs the user about the need to install the Bitbucket app for their commits.
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 29, 2025
@sergeibbb
Describes fixes in Changelog (#4192, #4243)
12b3618
@sergeibbb
Copy link
Member Author

sergeibbb commented Apr 29, 2025

@axosoft-ramint , @d13

I've fixed the problem. It turned out that ?api-version=7.1 attribute is required for this endpoint.

@sergeibbb sergeibbb requested a review from ramin-t April 29, 2025 08:55
@ramin-t
Copy link
Contributor

ramin-t commented Apr 29, 2025 •
edited
Loading

@sergeibbb On top of your latest changes, I'm still seeing the error everywhere. It is affecting nearly every query with Azure, including getPullRequestForCommit. Logs attached.
GitLens-1.log

@sergeibbb
Copy link
Member Author

sergeibbb commented Apr 29, 2025

@axosoft-ramint

Is Launchpad broken for Azure?

sergeibbb added a commit that referenced this pull request Apr 30, 2025
@sergeibbb
Fixes owner, project and repo retreival in Azure RemoteProvider for VSTS
3342c80 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 30, 2025
@sergeibbb
Implements getPullRequestForCommit for AzureDevOps
0b3902b 
(#4192, #4243)
@sergeibbb sergeibbb force-pushed the 4192-get-pr-for-commit branch from 12b3618 to e6242c7 Compare April 30, 2025 13:45
sergeibbb added a commit that referenced this pull request Apr 30, 2025
@sergeibbb
Implements gitPullRequestForCommit for Bitbucket
79ed437 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 30, 2025
@sergeibbb
Implements getPullRequestForCommit for Bitbucket DataCenter
7f473ec 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 30, 2025
@sergeibbb
Implements getAccountForCommit for Bitbucket
0d2ffc4 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 30, 2025
@sergeibbb
Implements getAccountForCommit for Bitbucket DataCenter
70fbb08 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 30, 2025
@sergeibbb
Implements getAccountForCommit for AzureDevOps
2ce8748 
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 30, 2025
@sergeibbb
Adds Bitbucket PR commit links app not installed warning
b03c3c6 
Displays a warning message when Bitbucket PR commit links are unavailable.
This informs the user about the need to install the Bitbucket app for their commits.
(#4192, #4243)
sergeibbb added a commit that referenced this pull request Apr 30, 2025
@sergeibbb
Describes fixes in Changelog (#4192, #4243)
e6242c7
@sergeibbb
Fixes owner, project and repo retreival in Azure RemoteProvider for VSTS
bfd53e9 
(#4192, #4243)
@sergeibbb
Implements getPullRequestForCommit for AzureDevOps
294cb1d 
(#4192, #4243)
@sergeibbb
Implements gitPullRequestForCommit for Bitbucket
72470f8 
(#4192, #4243)
@sergeibbb
Implements getPullRequestForCommit for Bitbucket DataCenter
8bb787a 
(#4192, #4243)
@sergeibbb
Implements getAccountForCommit for Bitbucket
17644f4 
(#4192, #4243)
@sergeibbb
Implements getAccountForCommit for Bitbucket DataCenter
aa81241 
(#4192, #4243)
@sergeibbb
Implements getAccountForCommit for AzureDevOps
6753ab2 
(#4192, #4243)
@sergeibbb
Adds Bitbucket PR commit links app not installed warning
b700e60 
Displays a warning message when Bitbucket PR commit links are unavailable.
This informs the user about the need to install the Bitbucket app for their commits.
(#4192, #4243)
@sergeibbb
Describes fixes in Changelog (#4192, #4243)
33a89b0
@sergeibbb sergeibbb force-pushed the 4192-get-pr-for-commit branch from e6242c7 to 33a89b0 Compare April 30, 2025 14:36
@sergeibbb
Copy link
Member Author

sergeibbb commented Apr 30, 2025

@axosoft-ramint

It might be a clue in azure-devops.ts.

Is your repository on dev.azure.com or is it visualstudio.net?

@sergeibbb
Copy link
Member Author

sergeibbb commented Apr 30, 2025

@axosoft-ramint

Can you please show what URL your repository has for this request on main branch:
image

ramin-t
ramin-t approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@ramin-t ramin-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to test this because I'm getting errors everywhere with my Azure connection/integration, but that will need to be investigated outside of this PR. Code LGTM - suggest having @d13 test it.

@ramin-t
Copy link
Contributor

ramin-t commented Apr 30, 2025

Going to land this and we can verify in pre-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramin-t ramin-t ramin-t approved these changes

@eamodio eamodio Awaiting requested review from eamodio

@d13 d13 Awaiting requested review from d13

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get "associated PR for commit" working on all providers that don't have it

3 participants

@sergeibbb @d13 @ramin-t