Skip to content

Refreshes expired integration sessions before use and improves error handling#4241

Merged
ramin-t merged 1 commit intomainfrom
4240-when-a-cloud-integration-token-expires-mid-session-we-do-not-attempt-to-refresh-it
Apr 24, 2025
Merged

Refreshes expired integration sessions before use and improves error handling#4241
ramin-t merged 1 commit intomainfrom
4240-when-a-cloud-integration-token-expires-mid-session-we-do-not-attempt-to-refresh-it

Conversation

@ramin-t
Copy link
Contributor

@ramin-t ramin-t commented Apr 18, 2025

Closes #4240

  • Ensures integration sessions are refreshed when expired before making requests.
  • Enhances error handling for provider API calls by throwing specific error types based on the HTTP status code.

@ramin-t ramin-t requested a review from eamodio April 18, 2025 21:50
@ramin-t ramin-t force-pushed the 4240-when-a-cloud-integration-token-expires-mid-session-we-do-not-attempt-to-refresh-it branch from 418ad37 to df7b727 Compare April 21, 2025 14:59
@ramin-t ramin-t requested a review from d13 April 21, 2025 20:49
Ensures that the integration session is refreshed if it has expired
before making requests to the provider.

Also improves error handling on provider API calls by throwing specific error types based on
the response status code.
@ramin-t ramin-t force-pushed the 4240-when-a-cloud-integration-token-expires-mid-session-we-do-not-attempt-to-refresh-it branch from df7b727 to 7be2e75 Compare April 23, 2025 14:57
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramin-t ramin-t merged commit 120864f into main Apr 24, 2025
3 checks passed
@ramin-t ramin-t deleted the 4240-when-a-cloud-integration-token-expires-mid-session-we-do-not-attempt-to-refresh-it branch April 24, 2025 15:12
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
Ensures that the integration session is refreshed if it has expired
before making requests to the provider.

Also improves error handling on provider API calls by throwing specific error types based on
the response status code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When a cloud integration token expires mid-session, we do not attempt to refresh it

2 participants