Adds IssueOrPullRequestType to cache keys for issue/PR retrieval#4233
Merged
Adds IssueOrPullRequestType to cache keys for issue/PR retrieval#4233
IssueOrPullRequestType to cache keys for issue/PR retrieval#4233Conversation
55a42b3 to
a03056a
Compare
a03056a to
fffa889
Compare
ramin-t
reviewed
Apr 16, 2025
Contributor
There was a problem hiding this comment.
I couldn't repro my original issue on this branch, so it seems to work. I would request, however, that you use IssueOrPullRequestType rather than AutolinkType so we can keep AutolinkType internal to the autolink domain where we can (and also because IssueOrPullRequestType is the type of the params being passed down from the integration in the places I checked).
fffa889 to
628fed7
Compare
Member
Author
|
@axosoft-ramint
Fixed |
AutolinkType to cache keys for issue/PR retrievalIssueOrPullRequestType to cache keys for issue/PR retrieval
628fed7 to
cb2026e
Compare
ramin-t
approved these changes
Apr 17, 2025
saeedzaha
pushed a commit
to saeedzaha/vscode-gitlens
that referenced
this pull request
Apr 28, 2025
preventing potential cache collisions. (gitkraken#4193, gitkraken#4233)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #4193
Description
Adds
IssueOrPullRequestTypeto cache keys for issue/PR retrieval preventing potential cache collisions.Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses