Skip to content

Adds create pr urls for other providers#4143

Merged
ramin-t merged 12 commits intomainfrom
feature/create-prs
Mar 27, 2025
Merged

Adds create pr urls for other providers#4143
ramin-t merged 12 commits intomainfrom
feature/create-prs

Conversation

@eamodio
Copy link
Member

@eamodio eamodio commented Mar 12, 2025

Refs #4142

@eamodio eamodio mentioned this pull request Mar 12, 2025
Closed
8 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2025
View reviewed changes
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Fixes compare and create-pr URLs for bitbucket-server
5003b13 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Fixes compare URL for bitbucket cloud
a0538f3 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 17, 2025
@sergeibbb
Fixes create-repo URL for bitbucket cloud
911b8b5 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 17, 2025
@sergeibbb
Gets provider resource URL asyncronously
fd15fa5 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 17, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
e2ca401 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
38021ba 
…k PR

(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Adds support for comparison and create pull request URLs in remote se…
9877724 
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Fixes compare and create-pr URLs for bitbucket-server
cede65a 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Fixes compare URL for bitbucket cloud
e7491b9 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Fixes create-repo URL for bitbucket cloud
aa105d0 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Gets provider resource URL asyncronously
5dc1f5d 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
ac01ae2 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
4705650 
…k PR

(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Adds support for comparison and create pull request URLs in remote se…
37c92d9 
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Gets provider resource URL asyncronously
7804bbf 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
95f5d83 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 18, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
f470126 
…k PR

(#4142, #4143)
@sergeibbb sergeibbb force-pushed the feature/create-prs branch from 38021ba to f470126 Compare March 18, 2025 21:24
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
e75a70b 
(#4142, #4143)
@sergeibbb sergeibbb force-pushed the feature/create-prs branch from f470126 to d324a33 Compare March 19, 2025 09:55
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
d324a33 
…k PR

(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare and create-pr URLs for bitbucket-server
b206ae0 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes compare URL for bitbucket cloud
5fedf22 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Fixes create-repo URL for bitbucket cloud
b2a27c8 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Gets provider resource URL asyncronously
df66dfb 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Retrieve target repoId for AzureDevOps
a87cac0 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
0ce9e8b 
…k PR

(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Generates create AzureDevOps PR URLs and retrieves repoId for cross-f…
c3cf1ff 
…orks

(#4142, #4143)
@sergeibbb sergeibbb force-pushed the feature/create-prs branch from 14b1c06 to d8ac382 Compare March 24, 2025 16:30
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Adds support for comparison and create pull request URLs in remote se…
a362744 
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Gets provider resource URL asyncronously
74ec306 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Generates create AzureDevOps PR URLs and retrieves repoId for cross-f…
4aac96f 
…orks

(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
751563e 
…k PR

(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Generates create GitLab PR URLs and retrieves repoId for cross-forks
13e7539 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Generates create Bitbucket PR URLs
bc7b710 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Generates create Bitbucket DataCenter PR URLs (without cross-forks)
d2e4b92 
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Generates create GitHub PR URLs
f0f6f67 
(#4142, #4143)
sergeibbb pushed a commit that referenced this pull request Mar 24, 2025
@eamodio @sergeibbb
Adds create pr urls for other providers
d8ac382 
(#4142, #4143)
@sergeibbb sergeibbb marked this pull request as ready for review March 24, 2025 16:31
@sergeibbb sergeibbb requested a review from ramin-t March 24, 2025 16:31
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Adds support for comparison and create pull request URLs in remote se…
85f76f0 
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Gets provider resource URL asyncronously
fd2e91e 
(#4142, #4143)
sergeibbb and others added 9 commits March 27, 2025 16:53
@sergeibbb
Adds support for comparison and create pull request URLs in remote se…
59b2670 
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
@sergeibbb
Gets provider resource URL asyncronously
7824100 
(#4142, #4143)
@sergeibbb
Generates create AzureDevOps PR URLs and retrieves repoId for cross-f…
37b442a 
…orks

(#4142, #4143)
@sergeibbb
Lets user connect and integration when it is required for a cross-for…
335e51e 
…k PR

(#4142, #4143)
@sergeibbb
Generates create GitLab PR URLs and retrieves repoId for cross-forks
9ee38b0 
(#4142, #4143)
@sergeibbb
Generates create Bitbucket PR URLs
28a5220 
(#4142, #4143)
@sergeibbb
Generates create Bitbucket DataCenter PR URLs (without cross-forks)
e53c6fb 
(#4142, #4143)
@sergeibbb
Generates create GitHub PR URLs
bf2d1d5 
(#4142, #4143)
@eamodio @sergeibbb
Adds create pr urls for other providers
2ccaefa 
(#4142, #4143)
eamodio
eamodio commented Mar 27, 2025
View reviewed changes
src/git/remotes/bitbucket-server.ts
options?: { title?: string; description?: string },
): string | undefined {
const query = new URLSearchParams({ sourceBranch: head.branch, targetBranch: base.branch ?? '' });
// TODO: figure this out
Copy link
Member Author

@eamodio eamodio Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this just need to be removed or figured out still?

Copy link
Member

@sergeibbb sergeibbb Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eamodio It's been waiting for bitbucket-server to be merged. But than I've switched to another task. So, yes, needs to be figured out.

@ramin-t
Copy link
Contributor

ramin-t commented Mar 27, 2025

In addition to @eamodio comments above, one other issue: whenever I cancel the process at any point after seeing the "connect to " prompt for cross-repository case, I see an error toast. We should not show an error in those cases.
image

@sergeibbb
Copy link
Member

sergeibbb commented Mar 27, 2025

@axosoft-ramint

whenever I cancel the process at any point after seeing the "connect to " prompt for cross-repository case, I see an error toast. We should not show an error in those cases.

fixed

ramin-t
ramin-t approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@ramin-t ramin-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - once the github security/CodeQL issue is fixed, we can proceed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramin-t ramin-t ramin-t approved these changes

@sergeibbb sergeibbb sergeibbb left review comments

Assignees

@ramin-t ramin-t

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Pull Request action fails for remotes other than GitHub

3 participants

@eamodio @ramin-t @sergeibbb