Skip to content

Bitbucket: Launchpad#4099

Merged
sergeibbb merged 8 commits intomainfrom
4046-bitbucket-launchpad
Mar 5, 2025
Merged

Bitbucket: Launchpad#4099
sergeibbb merged 8 commits intomainfrom
4046-bitbucket-launchpad

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Feb 24, 2025 •
edited
Loading

Description

solves #4046

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

The follow-up for improvement of the shared library: #4128

@sergeibbb sergeibbb marked this pull request as draft February 24, 2025 17:20
@sergeibbb sergeibbb marked this pull request as ready for review February 24, 2025 17:20
@sergeibbb sergeibbb marked this pull request as draft February 24, 2025 17:21
@sergeibbb sergeibbb force-pushed the 4045-home-pr-issue branch 2 times, most recently from 195a7ce to 317ea91 Compare February 25, 2025 14:13
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 0f22513 to aecdedf Compare February 25, 2025 14:21
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from aecdedf to cecf5a7 Compare February 25, 2025 14:22
@sergeibbb sergeibbb force-pushed the 4045-home-pr-issue branch 2 times, most recently from 6844237 to a328685 Compare February 25, 2025 14:28
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
c1f4ecc 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from cecf5a7 to c1f4ecc Compare February 25, 2025 14:31
@sergeibbb sergeibbb marked this pull request as ready for review February 25, 2025 14:31
@sergeibbb sergeibbb linked an issue Feb 25, 2025 that may be closed by this pull request
Bitbucket Cloud: Add Launchpad Support #4046
Closed
9 tasks
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
884e933 
(#4099)
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
81da91d 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
5e136fb 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
8faf9ed 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
55cedb2 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from c1f4ecc to 55cedb2 Compare February 25, 2025 14:47
@sergeibbb sergeibbb requested a review from ramin-t February 25, 2025 14:47
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
36fefdd 
(#4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
e04dff2 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 55cedb2 to 8b1c412 Compare February 26, 2025 08:57
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
f11e534 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
9edf0ee 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
8b1c412 
(#4046, #4099)
Base automatically changed from 4045-home-pr-issue to main February 26, 2025 10:52
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
c19777c 
(#4099)
sergeibbb added a commit that referenced this pull request Feb 28, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
28e72c9 
(#4099)
sergeibbb added a commit that referenced this pull request Feb 28, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
e4ce358 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 28, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
ec573bc 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 4cbc863 to fbba684 Compare February 28, 2025 11:50
sergeibbb added a commit that referenced this pull request Feb 28, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
8ce94df 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 28, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
fbba684 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 28, 2025
@sergeibbb
Moves resource descriptor types to models.ts
94c137b 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 93c4745 to 94c137b Compare February 28, 2025 11:59
sergeibbb added a commit that referenced this pull request Mar 1, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
60431d0 
(#4099)
sergeibbb added a commit that referenced this pull request Mar 1, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
dc227cf 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Mar 1, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
cfd1027 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 94c137b to 6935936 Compare March 1, 2025 00:10
sergeibbb added a commit that referenced this pull request Mar 1, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
d4376de 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Mar 1, 2025
@sergeibbb
Retrieves authoredPRs per workspace and reviewingPRs for current repo…
e0be140 
…s only

(#4046, #4099)
sergeibbb added a commit that referenced this pull request Mar 1, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
6935936 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Mar 1, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
3126886 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Mar 1, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
f11f946 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Mar 1, 2025
@sergeibbb
Retrieves authoredPRs per workspace and reviewingPRs for current repo…
d2885db 
…s only

(#4046, #4099)
ramin-t
ramin-t reviewed Mar 3, 2025
View reviewed changes
src/plus/integrations/providers/bitbucket.ts Outdated
Comment on lines +196 to +201
requestedRepositories?: BitbucketRepositoryDescriptor[],
): Promise<PullRequest[] | undefined> {
return Promise.resolve(undefined);
if (requestedRepositories != null) {
// TODO: implement repos version
return undefined;
}
Copy link
Contributor

@ramin-t ramin-t Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "requested repositories" would always be your open bitbucket repositories - they can be calculated here rather than passed in from above.

Copy link
Member Author

@sergeibbb sergeibbb Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axosoft-ramint
Do you mean that if they are passed, then I don't extract them from the context another time and just take the values from the argument?

Copy link
Contributor

@ramin-t ramin-t Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean we don't need requestedRepositories as an input here. This function should just use open repositories for the repo-specific query, and all your workspaces for the workspace-specific query.

Copy link
Member Author

@sergeibbb sergeibbb Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Just to ignore the content of this argument regardless if it's undefined or defined, like this a7effa4 ?

Copy link
Contributor

@ramin-t ramin-t Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake again here - we can keep this as is, just rename requestedRepositories to repos to align with the other providers.

Apologies for the confusion!

Copy link
Member Author

@sergeibbb sergeibbb Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axosoft-ramint

b0ef748 ?

ramin-t
ramin-t approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@ramin-t ramin-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure to follow up with shared library team on improvements to bitbucket queries.

@sergeibbb sergeibbb mentioned this pull request Mar 5, 2025
Closed
3 tasks
@sergeibbb
Copy link
Member Author

sergeibbb commented Mar 5, 2025

@axosoft-ramint

Please make sure to follow up with shared library team on improvements to bitbucket queries.

Here it is: #4128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramin-t ramin-t ramin-t approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bitbucket Cloud: Add Launchpad Support

2 participants

@sergeibbb @ramin-t