Merged
Conversation
sergeibbb
added a commit
that referenced
this pull request
Jan 24, 2025
7365a7c to
afe8f8c
Compare
sergeibbb
added a commit
that referenced
this pull request
Jan 24, 2025
sergeibbb
added a commit
that referenced
this pull request
Jan 27, 2025
sergeibbb
added a commit
that referenced
this pull request
Jan 27, 2025
afe8f8c to
f2bce05
Compare
sergeibbb
added a commit
that referenced
this pull request
Jan 27, 2025
sergeibbb
added a commit
that referenced
this pull request
Jan 27, 2025
f2bce05 to
2e58f76
Compare
5f05d75 to
15a2c4c
Compare
2e58f76 to
a317c9c
Compare
ramin-t
reviewed
Jan 27, 2025
Comment on lines
+673
to
+674
| case 'azure-devops': | ||
| return get(HostingIntegrationId.AzureDevOps) as RT; |
Contributor
There was a problem hiding this comment.
We probably need to check the remote's domain here and only return the azure devops id if it's non-enterprise. We don't support azure enterprise yet and should probably return undefined for that.
Member
Author
There was a problem hiding this comment.
@axosoft-ramint
Done.
Something like this?
Contributor
There was a problem hiding this comment.
I haven't tested it yet, but if you've verified by cloning an azure repo and making sure it passes this check, I think we should be good to go.
Member
Author
There was a problem hiding this comment.
Yes, I cloned both: a repo under dev.azure.com and another one under *.visualstudio.com
ramin-t
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #3976
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses