Skip to content

Fixes #1328 - Adds support for reading file history for files which o…#1330

Closed
sweiss3 wants to merge 4 commits intogitkraken:mainfrom
sweiss3:main
Closed

Fixes #1328 - Adds support for reading file history for files which o…#1330
sweiss3 wants to merge 4 commits intogitkraken:mainfrom
sweiss3:main

Conversation

@sweiss3
Copy link

@sweiss3 sweiss3 commented Jan 17, 2021 •
edited
Loading

Description

Fixes #1328 - Adds support for reading the file history for files which originate from symlinks

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sweiss3 sweiss3 force-pushed the main branch 2 times, most recently from 5b7a547 to 7a4179e Compare January 17, 2021 11:54
@sweiss3
Copy link
Author

sweiss3 commented Jan 25, 2021

To test, you can use the following repo:

https://github.com/sweiss3/SampleRepo1.git

Detailed steps:

git clone https://github.com/sweiss3/SampleRepo1.git
cd SampleRepo1
git submodule update --init --recursive
.\create_link.cmd

And open VSCode on SampleRepo1.

You will see that if you navigate to the text file inside LinkToSampleRepo2, GitLens will show an error in the console. With the PR applied, it should show the proper history.

@sweiss3
Copy link
Author

sweiss3 commented Feb 22, 2021

@eamodio Any comments/feedback on this?

glaukiol1
glaukiol1 approved these changes May 1, 2021
View reviewed changes
Copy link

@glaukiol1 glaukiol1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing

@sweiss3
Copy link
Author

sweiss3 commented May 9, 2021

@aekewu @glaukiol1 Thank you for your review.
Should I do anything to actively merge this? I'm not so proficient with GitHub just yet.

@sweiss3 sweiss3 closed this Aug 24, 2021
@sweiss3 sweiss3 reopened this Aug 24, 2021
@sweiss3
Copy link
Author

sweiss3 commented Aug 24, 2021

@eamodio Can this PR be merged? Is there any issue with it?

@sweiss3
Copy link
Author

sweiss3 commented Feb 20, 2023

@glaukiol1 Can you please advise on how to get this PR merged?

@Forest-Lover
Copy link
Contributor

Forest-Lover commented Nov 10, 2025

I need this feature too. Maybe it can be added as a setting option.
Is there any release vsix file for this change?

Forest-Lover added a commit to Forest-Lover/vscode-gitlens that referenced this pull request Nov 11, 2025
@Forest-Lover
Adds 'realpath' option to resolve symbolic links when determining fil…
2657209 
…e paths for Git operations (gitkraken#1330)
@Forest-Lover Forest-Lover mentioned this pull request Nov 11, 2025
Closed
Forest-Lover added a commit to Forest-Lover/vscode-gitlens that referenced this pull request Nov 11, 2025
@Forest-Lover
Adds 'realpath' option to resolve symbolic links when determining fil…
4cd6271 
…e paths for Git operations (gitkraken#1330)
sergeibbb pushed a commit that referenced this pull request Nov 18, 2025
@Forest-Lover @sergeibbb
Adds 'realpath' option to resolve symbolic links when determining fil…
f45a0c7 
…e paths for Git operations (#1330)
@sergeibbb
Copy link
Member

sergeibbb commented Nov 25, 2025 •
edited
Loading

the issue is fixed by another PR #4754

@sergeibbb sergeibbb closed this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@glaukiol1 glaukiol1 glaukiol1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitLens does not handle Windows junctions

5 participants

@sweiss3 @Forest-Lover @sergeibbb @glaukiol1 @shaharw3