chore(electron): Move off deprecated remote module#649
Merged
afonsojramos merged 7 commits intomainfrom Oct 9, 2023
Merged
Conversation
Collaborator
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
1 task
Collaborator
Author
|
This introduces a new issue, probably on a check for isLinux: |
a76fa67 to
46d82b4
Compare
Collaborator
Author
|
Fixed |
bmulholland
commented
Oct 3, 2023
32f92d6 to
81a8748
Compare
9fbb3a3 to
d756682
Compare
This was referenced Oct 4, 2023
afonsojramos
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a requirement for electron v14, which drops the module. We can do it before the upgrade, for smaller changes.