chore(deps): Remove history dependency#648
Merged
afonsojramos merged 7 commits intomainfrom Oct 24, 2023
Merged
Conversation
Collaborator
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
07e8eb3 to
98a9233
Compare
1 task
Collaborator
Author
|
Ah I guess the tests have that dependency still... WDYT @afonsojramos, should we swap the tests and remove the direct dependency? Or keep the dev dependency and just upgrade the package? |
Member
If there is an alternative to it, I think that we can/should remove it! |
Collaborator
Author
|
Wow, nice work. It's less code, too! |
afonsojramos
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was supposed to be removed as part of the react-router v6 upgrade (which moves history to a direct dependency), but it was clobbered by renovate