Consider go.sum to be generated#4660
Closed
nathany wants to merge 1 commit intogithub-linguist:masterfrom
nathany:gosum
Closed
Consider go.sum to be generated#4660nathany wants to merge 1 commit intogithub-linguist:masterfrom nathany:gosum
nathany wants to merge 1 commit intogithub-linguist:masterfrom
nathany:gosum
Conversation
Go 1.11 and newer include built in support for Go modules, with a user-editable go.mod file and a generated go.sum file. This flags go.sum as a generated file so that it will be suppressed in diffs.
Collaborator
|
See #4340. This was discussed in the past, and the eventual consensus was You can still exclude them in your projects by marking them as generated with an override. Just add this to your go.sum linguist-generated |
Author
|
Apologies, I only searched against open issues and pull requests. I respectfully disagree with the previous conclusion. When I have a pull request that updates dependencies, the actual code changes get lost after the giant go.sum diff. While the go.mod file should be reviewed, the go.sum is generated and need not be reviewed. Also, a generated file can still be expanded as needed. It doesn't make sense to consider Gopkg.lock and glide.lock as generated but not do the same for go.sum. |
Collaborator
|
Sigh... yes, this was precisely the catalyst of a long, long debate. In any case, you still have the option of hiding these files yourself. |
Author
|
Thanks for the tip. Works just as desired, so now I just need to go add it to every one of my Go repos. 🤦♂️ I guess I can see how some people might want to review the transitive dependency changes in the diff, but I really don't see reading through |
pchaigno
added a commit
to cilium/cilium
that referenced
this pull request
Apr 23, 2020
Mark go.sum files as generated to hide them in pull requests by default. They can still be uncollapsed if needed. This particular .gitattributes syntax is documented at [1]. GitHub doesn't hide them by default because some users may want to inspect these files (see [2] upstream for details). 1 - https://github.com/github/linguist/#using-gitattributes 2 - github-linguist/linguist#4660 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added a commit
to cilium/cilium
that referenced
this pull request
Apr 24, 2020
Mark go.sum files as generated to hide them in pull requests by default. They can still be uncollapsed if needed. This particular .gitattributes syntax is documented at [1]. GitHub doesn't hide them by default because some users may want to inspect these files (see [2] upstream for details). 1 - https://github.com/github/linguist/#using-gitattributes 2 - github-linguist/linguist#4660 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added a commit
to cilium/cilium
that referenced
this pull request
Apr 28, 2020
Mark go.sum files as generated to hide them in pull requests by default. They can still be uncollapsed if needed. This particular .gitattributes syntax is documented at [1]. GitHub doesn't hide them by default because some users may want to inspect these files (see [2] upstream for details). 1 - https://github.com/github/linguist/#using-gitattributes 2 - github-linguist/linguist#4660 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added a commit
to cilium/cilium
that referenced
this pull request
Apr 29, 2020
Mark go.sum files as generated to hide them in pull requests by default. They can still be uncollapsed if needed. This particular .gitattributes syntax is documented at [1]. GitHub doesn't hide them by default because some users may want to inspect these files (see [2] upstream for details). 1 - https://github.com/github/linguist/#using-gitattributes 2 - github-linguist/linguist#4660 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added a commit
to cilium/cilium
that referenced
this pull request
Apr 30, 2020
Mark go.sum files as generated to hide them in pull requests by default. They can still be uncollapsed if needed. This particular .gitattributes syntax is documented at [1]. GitHub doesn't hide them by default because some users may want to inspect these files (see [2] upstream for details). 1 - https://github.com/github/linguist/#using-gitattributes 2 - github-linguist/linguist#4660 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added a commit
to cilium/cilium
that referenced
this pull request
Apr 30, 2020
Mark go.sum files as generated to hide them in pull requests by default. They can still be uncollapsed if needed. This particular .gitattributes syntax is documented at [1]. GitHub doesn't hide them by default because some users may want to inspect these files (see [2] upstream for details). 1 - https://github.com/github/linguist/#using-gitattributes 2 - github-linguist/linguist#4660 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added a commit
to cilium/cilium
that referenced
this pull request
May 4, 2020
Mark go.sum files as generated to hide them in pull requests by default. They can still be uncollapsed if needed. This particular .gitattributes syntax is documented at [1]. GitHub doesn't hide them by default because some users may want to inspect these files (see [2] upstream for details). 1 - https://github.com/github/linguist/#using-gitattributes 2 - github-linguist/linguist#4660 Signed-off-by: Paul Chaignon <paul@cilium.io>
joestringer
pushed a commit
to cilium/cilium
that referenced
this pull request
May 4, 2020
Mark go.sum files as generated to hide them in pull requests by default. They can still be uncollapsed if needed. This particular .gitattributes syntax is documented at [1]. GitHub doesn't hide them by default because some users may want to inspect these files (see [2] upstream for details). 1 - https://github.com/github/linguist/#using-gitattributes 2 - github-linguist/linguist#4660 Signed-off-by: Paul Chaignon <paul@cilium.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.11 and newer include built in support for Go modules, with a user-editable go.mod file and a generated go.sum file.
This flags go.sum as a generated file so that it will be suppressed in diffs.
Checklist: