feat: Allow to disable runner max scaling check #3849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottGuymer
approved these changes
Apr 17, 2024
npalm
pushed a commit
that referenced
this pull request
Apr 17, 2024
🤖 I have created a release *beep* *boop* --- ## [5.10.0](philips-labs/terraform-aws-github-runner@v5.9.0...v5.10.0) (2024-04-17) ### Features * add spot termination watcher (beta) ([#3789](https://github.com/philips-labs/terraform-aws-github-runner/issues/3789)) ([b2dc794](philips-labs/terraform-aws-github-runner@b2dc794)) * allow caller to provide custom userdata ([#3798](https://github.com/philips-labs/terraform-aws-github-runner/issues/3798)) ([ac49daf](philips-labs/terraform-aws-github-runner@ac49daf)) * Allow to disable runner max scaling check ([#3849](https://github.com/philips-labs/terraform-aws-github-runner/issues/3849)) ([e05a043](philips-labs/terraform-aws-github-runner@e05a043)) ### Bug Fixes * **lambda:** bump axios from 1.6.7 to 1.6.8 in /lambdas ([#3814](https://github.com/philips-labs/terraform-aws-github-runner/issues/3814)) ([513b22f](philips-labs/terraform-aws-github-runner@513b22f)) * **lambda:** bump the aws group in /lambdas with 5 updates ([#3834](https://github.com/philips-labs/terraform-aws-github-runner/issues/3834)) ([e7e56ea](philips-labs/terraform-aws-github-runner@e7e56ea)) * **lambda:** bump the aws group in /lambdas with 5 updates ([#3846](https://github.com/philips-labs/terraform-aws-github-runner/issues/3846)) ([9303a10](philips-labs/terraform-aws-github-runner@9303a10)) * **lambda:** bump the aws group in /lambdas with 6 updates ([#3818](https://github.com/philips-labs/terraform-aws-github-runner/issues/3818)) ([9a9031e](philips-labs/terraform-aws-github-runner@9a9031e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to disable to maximum runner check when max runners is set to -1
Background
The maximum check is calling the AWS API describeInstances. When having a huge fleet of runners this call is expensive. Currently we have an issue with this API, this option allows to avoid calling the describeInstance API. Drawback is there will be nox safegouard for scaling.